Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Unified Diff: net/ssl/ssl_info.h

Issue 2349713004: Replace key_exchange_info with key_exchange_group. (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/ssl/ssl_cipher_suite_names.cc ('k') | net/ssl/ssl_info.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/ssl/ssl_info.h
diff --git a/net/ssl/ssl_info.h b/net/ssl/ssl_info.h
index 6015c24e87295343943208c4408362e8669f6ed6..645e28d8dccab7d0792864763a8ae1b7e923cfb3 100644
--- a/net/ssl/ssl_info.h
+++ b/net/ssl/ssl_info.h
@@ -51,10 +51,6 @@ class NET_EXPORT SSLInfo {
bool is_valid() const { return cert.get() != NULL; }
- // Returns the ID of the (EC)DH group used by the key exchange or zero if
- // unknown (older cache entries may not store the value) or not applicable.
- uint16_t GetKeyExchangeGroup() const;
-
// Adds the specified |error| to the cert status.
void SetCertError(int error);
@@ -86,14 +82,9 @@ class NET_EXPORT SSLInfo {
// -1 means the security strength is unknown.
int security_bits;
- // Security information of the SSL connection handshake.
- // The meaning depends on the cipher used, see BoringSSL's |SSL_SESSION|'s
- // key_exchange_info for more information.
- // A zero indicates that the value is unknown.
- //
- // This field is deprecated. Use GetKeyExchangeGroup instead. See
- // https://crbug.com/639421.
- int key_exchange_info;
+ // The ID of the (EC)DH group used by the key exchange or zero if unknown
+ // (older cache entries may not store the value) or not applicable.
+ uint16_t key_exchange_group;
// Information about the SSL connection itself. See
// ssl_connection_status_flags.h for values. The protocol version,
« no previous file with comments | « net/ssl/ssl_cipher_suite_names.cc ('k') | net/ssl/ssl_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698