Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Unified Diff: net/socket/ssl_client_socket_impl.cc

Issue 2349713004: Replace key_exchange_info with key_exchange_group. (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/chromium/quic_chromium_client_session.cc ('k') | net/socket/ssl_client_socket_pool.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/ssl_client_socket_impl.cc
diff --git a/net/socket/ssl_client_socket_impl.cc b/net/socket/ssl_client_socket_impl.cc
index 0af70d3e93c25de14b49efb57ddb37f3bcda5934..a0a8a3dd7860e572f97dfa1800d07b1f990c4aee 100644
--- a/net/socket/ssl_client_socket_impl.cc
+++ b/net/socket/ssl_client_socket_impl.cc
@@ -783,11 +783,8 @@ bool SSLClientSocketImpl::GetSSLInfo(SSLInfo* ssl_info) {
const SSL_CIPHER* cipher = SSL_get_current_cipher(ssl_);
CHECK(cipher);
ssl_info->security_bits = SSL_CIPHER_get_bits(cipher, NULL);
- if (SSL_CIPHER_is_ECDHE(cipher)) {
- ssl_info->key_exchange_info = SSL_get_curve_id(ssl_);
- } else if (SSL_CIPHER_is_DHE(cipher)) {
- ssl_info->key_exchange_info = SSL_get_dhe_group_size(ssl_);
- }
+ // Historically, the "group" was known as "curve".
+ ssl_info->key_exchange_group = SSL_get_curve_id(ssl_);
SSLConnectionStatusSetCipherSuite(
static_cast<uint16_t>(SSL_CIPHER_get_id(cipher)),
« no previous file with comments | « net/quic/chromium/quic_chromium_client_session.cc ('k') | net/socket/ssl_client_socket_pool.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698