Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Side by Side Diff: net/socket/ssl_client_socket_impl.cc

Issue 2349713004: Replace key_exchange_info with key_exchange_group. (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/quic/chromium/quic_chromium_client_session.cc ('k') | net/socket/ssl_client_socket_pool.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/socket/ssl_client_socket_impl.h" 5 #include "net/socket/ssl_client_socket_impl.h"
6 6
7 #include <errno.h> 7 #include <errno.h>
8 #include <openssl/bio.h> 8 #include <openssl/bio.h>
9 #include <openssl/bytestring.h> 9 #include <openssl/bytestring.h>
10 #include <openssl/err.h> 10 #include <openssl/err.h>
(...skipping 765 matching lines...) Expand 10 before | Expand all | Expand 10 after
776 ssl_info->token_binding_negotiated = tb_was_negotiated_; 776 ssl_info->token_binding_negotiated = tb_was_negotiated_;
777 ssl_info->token_binding_key_param = tb_negotiated_param_; 777 ssl_info->token_binding_key_param = tb_negotiated_param_;
778 ssl_info->pinning_failure_log = pinning_failure_log_; 778 ssl_info->pinning_failure_log = pinning_failure_log_;
779 ssl_info->ocsp_result = server_cert_verify_result_.ocsp_result; 779 ssl_info->ocsp_result = server_cert_verify_result_.ocsp_result;
780 780
781 AddCTInfoToSSLInfo(ssl_info); 781 AddCTInfoToSSLInfo(ssl_info);
782 782
783 const SSL_CIPHER* cipher = SSL_get_current_cipher(ssl_); 783 const SSL_CIPHER* cipher = SSL_get_current_cipher(ssl_);
784 CHECK(cipher); 784 CHECK(cipher);
785 ssl_info->security_bits = SSL_CIPHER_get_bits(cipher, NULL); 785 ssl_info->security_bits = SSL_CIPHER_get_bits(cipher, NULL);
786 if (SSL_CIPHER_is_ECDHE(cipher)) { 786 // Historically, the "group" was known as "curve".
787 ssl_info->key_exchange_info = SSL_get_curve_id(ssl_); 787 ssl_info->key_exchange_group = SSL_get_curve_id(ssl_);
788 } else if (SSL_CIPHER_is_DHE(cipher)) {
789 ssl_info->key_exchange_info = SSL_get_dhe_group_size(ssl_);
790 }
791 788
792 SSLConnectionStatusSetCipherSuite( 789 SSLConnectionStatusSetCipherSuite(
793 static_cast<uint16_t>(SSL_CIPHER_get_id(cipher)), 790 static_cast<uint16_t>(SSL_CIPHER_get_id(cipher)),
794 &ssl_info->connection_status); 791 &ssl_info->connection_status);
795 SSLConnectionStatusSetVersion(GetNetSSLVersion(ssl_), 792 SSLConnectionStatusSetVersion(GetNetSSLVersion(ssl_),
796 &ssl_info->connection_status); 793 &ssl_info->connection_status);
797 794
798 if (!SSL_get_secure_renegotiation_support(ssl_)) 795 if (!SSL_get_secure_renegotiation_support(ssl_))
799 ssl_info->connection_status |= SSL_CONNECTION_NO_RENEGOTIATION_EXTENSION; 796 ssl_info->connection_status |= SSL_CONNECTION_NO_RENEGOTIATION_EXTENSION;
800 797
(...skipping 1479 matching lines...) Expand 10 before | Expand all | Expand 10 after
2280 } 2277 }
2281 UMA_HISTOGRAM_ENUMERATION("DomainBoundCerts.Support", supported, 2278 UMA_HISTOGRAM_ENUMERATION("DomainBoundCerts.Support", supported,
2282 CHANNEL_ID_USAGE_MAX); 2279 CHANNEL_ID_USAGE_MAX);
2283 } 2280 }
2284 2281
2285 bool SSLClientSocketImpl::IsChannelIDEnabled() const { 2282 bool SSLClientSocketImpl::IsChannelIDEnabled() const {
2286 return ssl_config_.channel_id_enabled && channel_id_service_; 2283 return ssl_config_.channel_id_enabled && channel_id_service_;
2287 } 2284 }
2288 2285
2289 } // namespace net 2286 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/chromium/quic_chromium_client_session.cc ('k') | net/socket/ssl_client_socket_pool.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698