Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 2349603002: Make chrome/BUILD.gn use symlink.gni rather than symlink.py directly (Closed)

Created:
4 years, 3 months ago by agrieve
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make chrome/BUILD.gn use symlink.gni rather than symlink.py directly Committed: https://crrev.com/ca5b9cba81bf335ce205cc06e094587b25c79758 Cr-Commit-Position: refs/heads/master@{#419168}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -19 lines) Patch
M chrome/BUILD.gn View 2 chunks +4 lines, -19 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (5 generated)
agrieve
4 years, 3 months ago (2016-09-16 02:03:20 UTC) #2
Dirk Pranke
lgtm, but you'll need to copy some other owner as well, as I don't own ...
4 years, 3 months ago (2016-09-16 03:26:48 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 2348793002 Patch 1). Please resolve the dependency and ...
4 years, 3 months ago (2016-09-16 13:03:35 UTC) #6
agrieve
On 2016/09/16 03:26:48, Dirk Pranke wrote: > lgtm, but you'll need to copy some other ...
4 years, 3 months ago (2016-09-16 13:03:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349603002/1
4 years, 3 months ago (2016-09-16 13:50:05 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 14:55:29 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ca5b9cba81bf335ce205cc06e094587b25c79758 Cr-Commit-Position: refs/heads/master@{#419168}
4 years, 3 months ago (2016-09-16 14:57:05 UTC) #12
afakhry
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2344223002/ by afakhry@chromium.org. ...
4 years, 3 months ago (2016-09-16 16:47:38 UTC) #13
Dirk Pranke
4 years, 3 months ago (2016-09-16 19:45:28 UTC) #14
Message was sent while issue was closed.
On 2016/09/16 13:03:42, agrieve wrote:
> On 2016/09/16 03:26:48, Dirk Pranke wrote:
> > lgtm, but you'll need to copy some other owner as well, as I don't own this
> > file.
> 
> Looks like //build owners have per-file on //chrome/BUILD.gn

Ah, right, I forgot ;).

Powered by Google App Engine
This is Rietveld 408576698