Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Unified Diff: chrome/BUILD.gn

Issue 2349603002: Make chrome/BUILD.gn use symlink.gni rather than symlink.py directly (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index 8ddd74bb8a7a6cf025876d731a17514a5dd8a286..0cadfa69fd4cd1c58ebc4eb916bb960dcf5f0f6f 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -11,6 +11,7 @@ import("//build/config/sanitizers/sanitizers.gni")
import("//build/config/ui.gni")
import("//build/config/win/console_app.gni")
import("//build/config/win/manifest.gni")
+import("//build/symlink.gni")
import("//chrome/chrome_repack_locales.gni")
import("//chrome/common/features.gni")
import("//chrome/version.gni")
@@ -774,25 +775,9 @@ if (is_win) {
# root_out_dir, since copy_bundle_data copies the contents of the link
# rather than the link itself.
if (debug_devtools) {
- action("devtools_debug_resources") {
- _stamp = "$target_out_dir/run_${target_name}.stamp"
-
- outputs = [
- _stamp,
- ]
-
- script = "//build/symlink.py"
- args = [
- "-f",
- "--touch",
- rebase_path(_stamp, root_out_dir),
-
- # Convert the symlink source and destination to an absolute paths, which
- # makes symlinking easier (now pwd manipulation).
- rebase_path("$root_out_dir/resources/inspector"),
- rebase_path(
- "$root_out_dir/$chrome_product_full_name.app/Contents/Versions/$chrome_version_full/$chrome_framework_name.framework/Resources/inspector"),
- ]
+ symlink("devtools_debug_resources") {
+ source = "$root_out_dir/resources/inspector"
+ output = "$root_out_dir/$chrome_product_full_name.app/Contents/Versions/$chrome_version_full/$chrome_framework_name.framework/Resources/inspector"
deps = [
# Depend on :chrome_app to ensure that the bundle is produced before
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698