Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1826)

Side by Side Diff: chrome/BUILD.gn

Issue 2349603002: Make chrome/BUILD.gn use symlink.gni rather than symlink.py directly (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/buildflag_header.gni") 5 import("//build/buildflag_header.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/features.gni") 8 import("//build/config/features.gni")
9 import("//build/config/locales.gni") 9 import("//build/config/locales.gni")
10 import("//build/config/sanitizers/sanitizers.gni") 10 import("//build/config/sanitizers/sanitizers.gni")
11 import("//build/config/ui.gni") 11 import("//build/config/ui.gni")
12 import("//build/config/win/console_app.gni") 12 import("//build/config/win/console_app.gni")
13 import("//build/config/win/manifest.gni") 13 import("//build/config/win/manifest.gni")
14 import("//build/symlink.gni")
14 import("//chrome/chrome_repack_locales.gni") 15 import("//chrome/chrome_repack_locales.gni")
15 import("//chrome/common/features.gni") 16 import("//chrome/common/features.gni")
16 import("//chrome/version.gni") 17 import("//chrome/version.gni")
17 import("//third_party/widevine/cdm/widevine.gni") 18 import("//third_party/widevine/cdm/widevine.gni")
18 import("//ui/base/ui_features.gni") 19 import("//ui/base/ui_features.gni")
19 import("//v8/gni/v8.gni") 20 import("//v8/gni/v8.gni")
20 21
21 if (enable_resource_whitelist_generation) { 22 if (enable_resource_whitelist_generation) {
22 android_resource_whitelist = "$root_gen_dir/chrome/resource_whitelist.txt" 23 android_resource_whitelist = "$root_gen_dir/chrome/resource_whitelist.txt"
23 } 24 }
(...skipping 743 matching lines...) Expand 10 before | Expand all | Expand 10 after
767 public_deps += [ "//v8" ] 768 public_deps += [ "//v8" ]
768 } 769 }
769 } 770 }
770 771
771 # When debug_devtools is enabled, symlink the inspector resources into the 772 # When debug_devtools is enabled, symlink the inspector resources into the
772 # framework bundle. The resources go into the final output directory for the 773 # framework bundle. The resources go into the final output directory for the
773 # framework in the app bundle, rather than the framework bundle in 774 # framework in the app bundle, rather than the framework bundle in
774 # root_out_dir, since copy_bundle_data copies the contents of the link 775 # root_out_dir, since copy_bundle_data copies the contents of the link
775 # rather than the link itself. 776 # rather than the link itself.
776 if (debug_devtools) { 777 if (debug_devtools) {
777 action("devtools_debug_resources") { 778 symlink("devtools_debug_resources") {
778 _stamp = "$target_out_dir/run_${target_name}.stamp" 779 source = "$root_out_dir/resources/inspector"
779 780 output = "$root_out_dir/$chrome_product_full_name.app/Contents/Versions/$c hrome_version_full/$chrome_framework_name.framework/Resources/inspector"
780 outputs = [
781 _stamp,
782 ]
783
784 script = "//build/symlink.py"
785 args = [
786 "-f",
787 "--touch",
788 rebase_path(_stamp, root_out_dir),
789
790 # Convert the symlink source and destination to an absolute paths, which
791 # makes symlinking easier (now pwd manipulation).
792 rebase_path("$root_out_dir/resources/inspector"),
793 rebase_path(
794 "$root_out_dir/$chrome_product_full_name.app/Contents/Versions/$chro me_version_full/$chrome_framework_name.framework/Resources/inspector"),
795 ]
796 781
797 deps = [ 782 deps = [
798 # Depend on :chrome_app to ensure that the bundle is produced before 783 # Depend on :chrome_app to ensure that the bundle is produced before
799 # creating or destroying the symlink. 784 # creating or destroying the symlink.
800 ":chrome_app", 785 ":chrome_app",
801 "//third_party/WebKit/public:blink_devtools_frontend_resources", 786 "//third_party/WebKit/public:blink_devtools_frontend_resources",
802 ] 787 ]
803 } 788 }
804 } else { 789 } else {
805 group("devtools_debug_resources") { 790 group("devtools_debug_resources") {
(...skipping 956 matching lines...) Expand 10 before | Expand all | Expand 10 after
1762 "//chrome/app/theme/$branding_path_component/product_logo_48.png", 1747 "//chrome/app/theme/$branding_path_component/product_logo_48.png",
1763 "//chrome/tools/build/linux/chrome-wrapper", 1748 "//chrome/tools/build/linux/chrome-wrapper",
1764 "//third_party/xdg-utils/scripts/xdg-mime", 1749 "//third_party/xdg-utils/scripts/xdg-mime",
1765 "//third_party/xdg-utils/scripts/xdg-settings", 1750 "//third_party/xdg-utils/scripts/xdg-settings",
1766 ] 1751 ]
1767 outputs = [ 1752 outputs = [
1768 "$root_out_dir/{{source_file_part}}", 1753 "$root_out_dir/{{source_file_part}}",
1769 ] 1754 ]
1770 } 1755 }
1771 } 1756 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698