Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2348793002: Use a stamp file when symlinking in GN work around mtime issues (Closed)

Created:
4 years, 3 months ago by agrieve
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use a stamp file when symlinking in GN work around mtime issues Ninja follows a symlink when stat'ing, so you can't use a symlink as an output and have dirty checking work properly. https://github.com/ninja-build/ninja/issues/1186 BUG=646165 Committed: https://crrev.com/fef37c4393d059c9125353928de7e49d4ea04ab4 Cr-Commit-Position: refs/heads/master@{#419156}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M build/symlink.gni View 1 chunk +7 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (9 generated)
agrieve
On 2016/09/16 02:01:37, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:dpranke@chromium.org
4 years, 3 months ago (2016-09-16 02:01:42 UTC) #4
Dirk Pranke
lgtm
4 years, 3 months ago (2016-09-16 03:25:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2348793002/1
4 years, 3 months ago (2016-09-16 13:04:15 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 13:37:35 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fef37c4393d059c9125353928de7e49d4ea04ab4 Cr-Commit-Position: refs/heads/master@{#419156}
4 years, 3 months ago (2016-09-16 13:40:01 UTC) #14
afakhry
4 years, 3 months ago (2016-09-16 16:49:19 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2348493005/ by afakhry@chromium.org.

The reason for reverting is: Breaks BuildPackages due to GN error
(https://bugs.chromium.org/p/chromium/issues/detail?id=647706).

BUG=647706.

Powered by Google App Engine
This is Rietveld 408576698