Update USBConnectionEvent.idl to match the spec.

Update USBConnectionEvent.idl to match the spec.

The spec has been updated to properly define a constructor for
USBConnectionEvent. This patch updates Blink's version of the IDL to
match.

Committed: https://crrev.com/bce2e76bb44542c850aacd6b5f7637760a53f3b6
Cr-Commit-Position: refs/heads/master@{#421115}

[Reilly Grant (use Gerrit), 2016-09-16 00:35:44]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 00:36:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 03:02:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 03:02:20]

Dry run: This issue passed the CQ dry run.

[Reilly Grant (use Gerrit), 2016-09-16 19:49:19]

reillyg@chromium.org changed reviewers:
+ jyasskin@chromium.org

[Reilly Grant (use Gerrit), 2016-09-16 19:49:20]

Jeffrey, please take a look.

[haraken, 2016-09-17 00:02:01]

Can we have a test?

[Jeffrey Yasskin, 2016-09-26 22:29:08]

On 2016/09/16 19:49:20, Reilly Grant wrote:
> Jeffrey, please take a look.

LGTM, except that a test does look straightforward here, checking that a missing
.device or omitted argument causes a TypeError.

[Reilly Grant (use Gerrit), 2016-09-27 00:55:27]

On 2016/09/26 at 22:29:08, jyasskin wrote:
> On 2016/09/16 19:49:20, Reilly Grant wrote:
> > Jeffrey, please take a look.
> 
> LGTM, except that a test does look straightforward here, checking that a
missing .device or omitted argument causes a TypeError.

I was hesitant to add a test that just verifies that the generated V8 bindings
are correct but I will do so.

[Reilly Grant (use Gerrit), 2016-09-27 02:31:47]

Add tests.

[Reilly Grant (use Gerrit), 2016-09-27 02:31:53]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 02:32:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 04:00:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 04:00:13]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Reilly Grant (use Gerrit), 2016-09-27 04:00:53]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2016-09-27 04:00:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
jyasskin@chromium.org
Link to the patchset: https://codereview.chromium.org/2348703003/#ps20001
(title: "Add tests.")

[commit-bot: I haz the power, 2016-09-27 04:01:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 05:19:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-27 05:21:55]

Description was changed from

==========
Update USBConnectionEvent.idl to match the spec.

The spec has been updated to properly define a constructor for
USBConnectionEvent. This patch updates Blink's version of the IDL to
match.
==========

to

==========
Update USBConnectionEvent.idl to match the spec.

The spec has been updated to properly define a constructor for
USBConnectionEvent. This patch updates Blink's version of the IDL to
match.

Committed: https://crrev.com/bce2e76bb44542c850aacd6b5f7637760a53f3b6
Cr-Commit-Position: refs/heads/master@{#421115}
==========

[commit-bot: I haz the power, 2016-09-27 05:21:56]

Patchset 2 (id:??) landed as
https://crrev.com/bce2e76bb44542c850aacd6b5f7637760a53f3b6
Cr-Commit-Position: refs/heads/master@{#421115}

[Jeffrey Yasskin, 2016-09-27 19:54:57]

https://codereview.chromium.org/2348703003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/usb/usb-connection-event.html (right):

https://codereview.chromium.org/2348703003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/usb/usb-connection-event.html:23: new
USBConnectionEvent('connect', { device: null });
FWIW, I think you can use promise_rejects() for this:
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/resources...

I forget the exact syntax for asserting that it's a TypeError.

[Reilly Grant (use Gerrit), 2016-09-28 02:07:24]

https://codereview.chromium.org/2348703003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/usb/usb-connection-event.html (right):

https://codereview.chromium.org/2348703003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/usb/usb-connection-event.html:23: new
USBConnectionEvent('connect', { device: null });
On 2016/09/27 at 19:54:57, Jeffrey Yasskin wrote:
> FWIW, I think you can use promise_rejects() for this:
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/resources...
> 
> I forget the exact syntax for asserting that it's a TypeError.

There is assert_throws() but it only accepts DOMExceptions as the expected error
and TypeError is a pure JavaScript concept.

[Jeffrey Yasskin, 2016-09-28 20:21:52]

https://codereview.chromium.org/2348703003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/usb/usb-connection-event.html (right):

https://codereview.chromium.org/2348703003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/usb/usb-connection-event.html:23: new
USBConnectionEvent('connect', { device: null });
On 2016/09/28 02:07:24, Reilly Grant wrote:
> On 2016/09/27 at 19:54:57, Jeffrey Yasskin wrote:
> > FWIW, I think you can use promise_rejects() for this:
>
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/resources...
> > 
> > I forget the exact syntax for asserting that it's a TypeError.
> 
> There is assert_throws() but it only accepts DOMExceptions as the expected
error
> and TypeError is a pure JavaScript concept.

It turns out that TypeError() works, while 'TypeError' doesn't. I learned this
from https://github.com/w3c/testharness.js/issues/62 and have now sent
https://github.com/w3c/testharness.js/pull/211 to make 'TypeError' work too.