third_party/WebKit/Source/modules/webusb/USBConnectionEvent.cpp - Issue 2348703003: Update USBConnectionEvent.idl to match the spec.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webusb/USBConnectionEvent.cpp

Issue 2348703003: Update USBConnectionEvent.idl to match the spec. (Closed)

Patch Set: Add tests. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webusb/USBConnectionEvent.cpp

diff --git a/third_party/WebKit/Source/modules/webusb/USBConnectionEvent.cpp b/third_party/WebKit/Source/modules/webusb/USBConnectionEvent.cpp

index 507356ee355c599abeaa4e006f3f5b432213ecf7..4725fda5463193d689b9e2c0f724d3dde4f41000 100644

--- a/third_party/WebKit/Source/modules/webusb/USBConnectionEvent.cpp

+++ b/third_party/WebKit/Source/modules/webusb/USBConnectionEvent.cpp

@@ -21,10 +21,8 @@ USBConnectionEvent* USBConnectionEvent::create(const AtomicString& type, USBDevi

USBConnectionEvent::USBConnectionEvent(const AtomicString& type, const USBConnectionEventInit& initializer)

: Event(type, initializer)

- , m_device(nullptr)

+ , m_device(initializer.device())

{

- if (initializer.hasDevice())

- m_device = initializer.device();

}

USBConnectionEvent::USBConnectionEvent(const AtomicString& type, USBDevice* device)