Chromium Code Reviews Chromium Code Reviews
Issue 2348703003:
Update USBConnectionEvent.idl to match the spec. (Closed)
| Index: third_party/WebKit/LayoutTests/usb/usb-connection-event.html |
| diff --git a/third_party/WebKit/LayoutTests/usb/usb-connection-event.html b/third_party/WebKit/LayoutTests/usb/usb-connection-event.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..79df711b57c0d967e7717edc6f339d681714ebaa |
| --- /dev/null |
| +++ b/third_party/WebKit/LayoutTests/usb/usb-connection-event.html |
| @@ -0,0 +1,36 @@ |
| +<!DOCTYPE html> |
| +<script src="../resources/testharness.js"></script> |
| +<script src="../resources/testharnessreport.js"></script> |
| +<script src="../resources/mojo-helpers.js"></script> |
| +<script src="resources/fake-devices.js"></script> |
| +<script src="resources/usb-helpers.js"></script> |
| +<script> |
| +'use strict'; |
| + |
| +usb_test(usb => { |
| + usb.mockDeviceManager.addMockDevice(usb.fakeDevices[0]); |
| + |
| + return navigator.usb.getDevices().then(devices => { |
| + assert_equals(devices.length, 1); |
| + let evt = new USBConnectionEvent('connect', { device: devices[0] }); |
| + assert_equals(evt.type, 'connect'); |
| + assert_equals(evt.device, devices[0]); |
| + }); |
| +}, 'Can construct a USBConnectionEvent with a device'); |
| + |
| +test(t => { |
| + try { |
| + new USBConnectionEvent('connect', { device: null }); |
|
Jeffrey Yasskin
2016/09/27 19:54:57
FWIW, I think you can use promise_rejects() for th
Reilly Grant (use Gerrit)
2016/09/28 02:07:24
There is assert_throws() but it only accepts DOMEx
Jeffrey Yasskin
2016/09/28 20:21:52
It turns out that TypeError() works, while 'TypeEr
|
| + assert_unreached('expected TypeError'); |
| + } catch (err) { |
| + assert_true(err instanceof TypeError); |
| + } |
| + |
| + try { |
| + new USBConnectionEvent('connect', {}) |
| + assert_unreached('expected TypeError'); |
| + } catch (err) { |
| + assert_true(err instanceof TypeError); |
| + } |
| +}, 'Cannot construct a USBConnectionEvent without a device'); |
| +</script> |
