Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/modules/webusb/USBConnectionEventInit.idl

Issue 2348703003: Update USBConnectionEvent.idl to match the spec. (Closed)
Patch Set: Add tests. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/LayoutTests/usb/usb-connection-event.html ('K') | « third_party/WebKit/Source/modules/webusb/USBConnectionEvent.idl ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/webusb/USBConnectionEventInit.idl
diff --git a/third_party/WebKit/Source/modules/webusb/USBConnectionEventInit.idl b/third_party/WebKit/Source/modules/webusb/USBConnectionEventInit.idl
index 78433c40da88eb4a3c1cbbcb0c8477f31ddc9289..d79d0ff1f87e0d067e241c79016b9576505141d5 100644
--- a/third_party/WebKit/Source/modules/webusb/USBConnectionEventInit.idl
+++ b/third_party/WebKit/Source/modules/webusb/USBConnectionEventInit.idl
@@ -5,8 +5,5 @@
// http://wicg.github.io/webusb/#events
dictionary USBConnectionEventInit : EventInit {
- // TODO(foolip): |device| should be required and not nullable.
- // https://crbug.com/647693
- // https://github.com/WICG/webusb/issues/63
- USBDevice? device;
+ required USBDevice device;
};
« third_party/WebKit/LayoutTests/usb/usb-connection-event.html ('K') | « third_party/WebKit/Source/modules/webusb/USBConnectionEvent.idl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698