Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2348643002: Revert of Enable whitelisting for targets other than libchrome. (Closed)

Created:
4 years, 3 months ago by miu
Modified:
4 years, 3 months ago
Reviewers:
brettw, agrieve
CC:
chromium-reviews, extensions-reviews_chromium.org, alemate+watch_chromium.org, dtseng+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, sdefresne+watch_chromium.org, android-webview-reviews_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable whitelisting for targets other than libchrome. (patchset #8 id:40002 of https://codereview.chromium.org/2336033002/ ) Reason for revert: Broke ninja on Linux x64: ninja: Entering directory `out/Release' [1/1] Regenerating ninja files FAILED: build.ninja /mnt/ssd/miu/chromium/src/buildtools/linux64/gn --root=/mnt/ssd/miu/chromium/src -q gen //out/Release/ ERROR at //chrome/BUILD.gn:1358:5: Undefined identifier. public_deps += [ ":default_apps" ] ^---------- See //BUILD.gn:211:7: which caused the file to be included. "//chrome", ^--------- ninja: error: rebuilding 'build.ninja': subcommand failed Original issue's description: > Refactor chrome resource targets into chrome_paks.gni > > This will allow monochrome to easily define its own set of the same > targets with a different resource whitelist > > BUG=641032 > > Committed: https://crrev.com/33312c3d3dc09f27325e74644b346123b325891e > Cr-Commit-Position: refs/heads/master@{#418966} TBR=brettw@chromium.org,agrieve@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=641032 Committed: https://crrev.com/be4eedd9735c6daf3c30709e10e14f17b955a886 Cr-Commit-Position: refs/heads/master@{#418992}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -257 lines) Patch
M chrome/BUILD.gn View 7 chunks +212 lines, -34 lines 0 comments Download
D chrome/chrome_paks.gni View 1 chunk +0 lines, -220 lines 0 comments Download
M chrome/chrome_repack_locales.gni View 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
miu
Created Revert of Enable whitelisting for targets other than libchrome.
4 years, 3 months ago (2016-09-15 21:44:55 UTC) #2
miu
On 2016/09/15 21:44:55, miu wrote: > Created Revert of Enable whitelisting for targets other than ...
4 years, 3 months ago (2016-09-15 21:45:15 UTC) #4
miu
On 2016/09/15 21:45:15, miu wrote: > On 2016/09/15 21:44:55, miu wrote: > > Created Revert ...
4 years, 3 months ago (2016-09-15 21:46:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2348643002/1
4 years, 3 months ago (2016-09-15 21:47:05 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 21:48:54 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/be4eedd9735c6daf3c30709e10e14f17b955a886 Cr-Commit-Position: refs/heads/master@{#418992}
4 years, 3 months ago (2016-09-15 21:51:09 UTC) #12
agrieve
4 years, 3 months ago (2016-09-16 00:17:26 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2344063002/ by agrieve@chromium.org.

The reason for reverting is: Will update when fixed.

Powered by Google App Engine
This is Rietveld 408576698