Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2336033002: Enable whitelisting for targets other than libchrome. (Closed)

Created:
4 years, 3 months ago by agrieve
Modified:
4 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews, extensions-reviews_chromium.org, alemate+watch_chromium.org, dtseng+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, sdefresne+watch_chromium.org, android-webview-reviews_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor chrome resource targets into chrome_paks.gni This will allow monochrome to easily define its own set of the same targets with a different resource whitelist BUG=641032 Committed: https://crrev.com/33312c3d3dc09f27325e74644b346123b325891e Cr-Commit-Position: refs/heads/master@{#418966}

Patch Set 1 #

Patch Set 2 : 🎃 #

Patch Set 3 : don't change output_dir #

Patch Set 4 : 🍷 #

Patch Set 5 : 🍹 #

Patch Set 6 : 🎈 #

Patch Set 7 : 🎄 #

Patch Set 8 : 🎀 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+255 lines, -218 lines) Patch
M chrome/BUILD.gn View 1 2 3 4 5 6 7 7 chunks +32 lines, -210 lines 0 comments Download
A chrome/chrome_paks.gni View 1 2 1 chunk +220 lines, -0 lines 0 comments Download
M chrome/chrome_repack_locales.gni View 1 2 3 4 2 chunks +3 lines, -8 lines 0 comments Download

Messages

Total messages: 44 (37 generated)
agrieve
On 2016/09/15 19:59:37, agrieve wrote: > The CQ bit was checked by mailto:agrieve@chromium.org to run ...
4 years, 3 months ago (2016-09-15 19:59:57 UTC) #34
brettw
rs lgtm
4 years, 3 months ago (2016-09-15 20:18:42 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2336033002/40002
4 years, 3 months ago (2016-09-15 20:25:53 UTC) #38
commit-bot: I haz the power
Committed patchset #8 (id:40002)
4 years, 3 months ago (2016-09-15 20:54:45 UTC) #40
commit-bot: I haz the power
Patchset 8 (id:??) landed as https://crrev.com/33312c3d3dc09f27325e74644b346123b325891e Cr-Commit-Position: refs/heads/master@{#418966}
4 years, 3 months ago (2016-09-15 20:57:43 UTC) #42
miu
A revert of this CL (patchset #8 id:40002) has been created in https://codereview.chromium.org/2348643002/ by miu@chromium.org. ...
4 years, 3 months ago (2016-09-15 21:44:54 UTC) #43
agrieve
4 years, 3 months ago (2016-09-16 00:17:00 UTC) #44
Message was sent while issue was closed.
A revert of this CL (patchset #8 id:40002) has been created in
https://codereview.chromium.org/2340383003/ by agrieve@chromium.org.

The reason for reverting is: will update when fixed.

Powered by Google App Engine
This is Rietveld 408576698