Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Issue 2344063002: Reland of Enable whitelisting for targets other than libchrome. (Closed)

Created:
4 years, 3 months ago by agrieve
Modified:
4 years, 3 months ago
Reviewers:
brettw, miu
CC:
chromium-reviews, extensions-reviews_chromium.org, alemate+watch_chromium.org, dtseng+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, sdefresne+watch_chromium.org, android-webview-reviews_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Enable whitelisting for targets other than libchrome. Reverted in: https://codereview.chromium.org/2348643002/ Reason for revert: Fixed gn gen errror This will allow monochrome to easily define its own set of the same targets with a different resource whitelist TBR=brettw@chromium.org,miu@chromium.org BUG=641032 Committed: https://crrev.com/26cf65711c693aac13c897b67d0e138c3ee42ece Cr-Commit-Position: refs/heads/master@{#419074}

Patch Set 1 #

Patch Set 2 : fix gn gen #

Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -217 lines) Patch
M chrome/BUILD.gn View 1 7 chunks +33 lines, -209 lines 0 comments Download
A chrome/chrome_paks.gni View 1 chunk +220 lines, -0 lines 0 comments Download
M chrome/chrome_repack_locales.gni View 1 2 chunks +3 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
agrieve
Created Reland of Enable whitelisting for targets other than libchrome.
4 years, 3 months ago (2016-09-16 00:17:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2344063002/90001
4 years, 3 months ago (2016-09-16 00:21:52 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:90001)
4 years, 3 months ago (2016-09-16 01:48:36 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/26cf65711c693aac13c897b67d0e138c3ee42ece Cr-Commit-Position: refs/heads/master@{#419074}
4 years, 3 months ago (2016-09-16 01:51:14 UTC) #8
Yuta Kitamura
A revert of this CL (patchset #2 id:90001) has been created in https://codereview.chromium.org/2342243003/ by yutak@chromium.org. ...
4 years, 3 months ago (2016-09-16 04:25:32 UTC) #9
xdai1
4 years, 3 months ago (2016-09-16 05:50:22 UTC) #10
Message was sent while issue was closed.
FYI: It also caused all the chrome information builders[1] fail, see
https://bugs.chromium.org/p/chromium/issues/detail?id=647488 for error message.
After the revert, the informational builders started to cycle green.

[1] example builder:
https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/x86-alex-tot-...
and you can find the log here:
https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/x86-alex-tot-...

Powered by Google App Engine
This is Rietveld 408576698