Moving platform tracing things into platform/tracing.

Moving platform tracing things into platform/tracing.

Lets move all of the tracing related things together. This doesn't add
an OWNERS file yet since we still need to sort out what team owns this
code.

Note: I had to skip the presubmit since TraceEventCommon is covered in
style violations since it's a copy paste of some base code, there's also
some ASSERTs that it wants to be made into DCHECKs. I don't want to
change any code in this patch though, this is purely a move.

BUG=642096
NOPRESUBMIT=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

[esprehn, 2016-09-16 00:05:27]

Description was changed from

==========
Moving platform tracing things into platform/tracing.

Lets move all of the tracing related things together. This doesn't add
an OWNERS file yet since we still need to sort out what team owns this
code.

Note: I had to skip the presubmit since TraceEventCommon is covered in
style violations since it's a copy paste of some base code, there's also
some ASSERTs that it wants to be made into DCHECKs. I don't want to
change any code in this patch though, this is purely a move.

BUG=642096
NOPRESUBMIT=true
==========

to

==========
Moving platform tracing things into platform/tracing.

Lets move all of the tracing related things together. This doesn't add
an OWNERS file yet since we still need to sort out what team owns this
code.

Note: I had to skip the presubmit since TraceEventCommon is covered in
style violations since it's a copy paste of some base code, there's also
some ASSERTs that it wants to be made into DCHECKs. I don't want to
change any code in this patch though, this is purely a move.

BUG=642096
NOPRESUBMIT=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[esprehn, 2016-09-16 00:06:13]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 00:06:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[esprehn, 2016-09-16 02:26:25]

esprehn@chromium.org changed reviewers:
+ dglazkov@chromium.org, haraken@chromium.org

[commit-bot: I haz the power, 2016-09-16 02:31:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 02:31:09]

Dry run: This issue passed the CQ dry run.

[haraken, 2016-09-16 07:51:32]

LGTM

I'd add (at least) primiano@ to platform/tracing/OWNERS.

https://codereview.chromium.org/2346663004/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/MemoryCacheDumpProvider.h (right):

https://codereview.chromium.org/2346663004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/MemoryCacheDumpProvider.h:6: #define
MemoryCacheDumpProvider_h

Shouldn't we remove this file, since we're moving MemoryCacheDumpProvider to
platform/tracing/?

https://codereview.chromium.org/2346663004/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/tracing/TraceEvent.h (right):

https://codereview.chromium.org/2346663004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/tracing/TraceEvent.h:44: // Implementation
specific tracing API definitions.

This is clearly out of the scope of this CL, but we should really consider
unifying the implementation with base::trace_event.

https://codereview.chromium.org/2346663004/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/tracing/TraceEventCommon.h (right):

https://codereview.chromium.org/2346663004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/tracing/TraceEventCommon.h:12: // IMPORTANT:
To avoid conflicts, if you need to modify this file for a library,

Ditto. We should unify the tracing macros with Chromium and remove
TraceEventCommon.h entirely.

[jbroman, 2016-09-16 12:02:11]

https://codereview.chromium.org/2346663004/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/tracing/TraceEvent.h (right):

https://codereview.chromium.org/2346663004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/tracing/TraceEvent.h:44: // Implementation
specific tracing API definitions.
On 2016/09/16 at 07:51:32, haraken wrote:
> This is clearly out of the scope of this CL, but we should really consider
unifying the implementation with base::trace_event.

FYI, wangxianzhu@ says he intends to do this:
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/CyMqAd0Kld4/VS-qA...

[haraken, 2016-09-16 12:04:00]

On 2016/09/16 12:02:11, jbroman wrote:
>
https://codereview.chromium.org/2346663004/diff/1/third_party/WebKit/Source/p...
> File third_party/WebKit/Source/platform/tracing/TraceEvent.h (right):
> 
>
https://codereview.chromium.org/2346663004/diff/1/third_party/WebKit/Source/p...
> third_party/WebKit/Source/platform/tracing/TraceEvent.h:44: // Implementation
> specific tracing API definitions.
> On 2016/09/16 at 07:51:32, haraken wrote:
> > This is clearly out of the scope of this CL, but we should really consider
> unifying the implementation with base::trace_event.
> 
> FYI, wangxianzhu@ says he intends to do this:
>
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/CyMqAd0Kld4/VS-qA...

That is amazing!!

[esprehn, 2016-10-05 03:40:00]

esprehn@chromium.org changed reviewers:
+ wangxianzhu@chromium.org

[esprehn, 2016-10-05 03:40:02]

wangxianzhu@ Would you be willing to finish this move of the files into
platform/tracing and make yourself an OWNER of it? :)

[Xianzhu, 2016-10-05 15:45:41]

On 2016/10/05 03:40:02, esprehn wrote:
> wangxianzhu@ Would you be willing to finish this move of the files into
> platform/tracing and make yourself an OWNER of it? :)

Sure. Will do.