Use chromium trace_event implementation in blink

Use chromium trace_event implementation in blink

Previously blink's trace_event was implemented in the way to make
blink a standalone library:
   TRACE_EVENT macros
-> TRACE_EVENT internal macros
-> EventTracer
-> Chromium's trace event C++ API

Now blink is no longer a standalone library, so we can use chromium's
trace_event macros directly.

This CL
- removes blink's trace_event implementation
- lets blink's TraceEvent.h include chromium's trace_event.h,
- lets blink's TracedValue implement ConvertableToTraceFormat,
- keeps support of blink CString type as trace values.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/f1acd2dd9f935f7d29dcee651f84eac16761609f
Cr-Commit-Position: refs/heads/master@{#419897}

[Xianzhu, 2016-09-17 04:32:34]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-17 04:32:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-17 04:36:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-17 04:36:47]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[Xianzhu, 2016-09-18 03:57:41]

wangxianzhu@chromium.org changed reviewers:
+ esprehn@chromium.org, haraken@chromium.org

[Xianzhu, 2016-09-19 17:18:37]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 17:18:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-09-19 17:19:32]

wangxianzhu@chromium.org changed reviewers:
+ primiano@chromium.org

[commit-bot: I haz the power, 2016-09-19 17:22:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 17:22:47]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xianzhu, 2016-09-19 18:13:48]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 18:14:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 20:16:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 20:16:34]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[haraken, 2016-09-20 00:49:12]

This looks amazing! LGTM

Add more explanation to the CL description so that other developers can follow
what this CL is doing.

[Xianzhu, 2016-09-20 02:54:04]

Description was changed from

==========
Use chromium trace_event implementation in blink
==========

to

==========
Use chromium trace_event implementation in blink

Previously blink's trace_event was implemented in the way to make
blink a standalone library:
   TRACE_EVENT macros
-> TRACE_EVENT internal macros
-> EventTracer
-> Chromium's trace event C++ API

Now blink is no longer a standalone library, so we can use chromium's
trace_event macros directly.

This CL
- removes blink's trace_event implementation
- lets blink's TraceEvent.h include chromium's trace_event.h,
- lets blink's TracedValue implement ConvertableToTraceFormat,
- keeps support of blink CString type as trace values.
==========

[Xianzhu, 2016-09-20 05:38:24]

Description was changed from

==========
Use chromium trace_event implementation in blink

Previously blink's trace_event was implemented in the way to make
blink a standalone library:
   TRACE_EVENT macros
-> TRACE_EVENT internal macros
-> EventTracer
-> Chromium's trace event C++ API

Now blink is no longer a standalone library, so we can use chromium's
trace_event macros directly.

This CL
- removes blink's trace_event implementation
- lets blink's TraceEvent.h include chromium's trace_event.h,
- lets blink's TracedValue implement ConvertableToTraceFormat,
- keeps support of blink CString type as trace values.
==========

to

==========
Use chromium trace_event implementation in blink

Previously blink's trace_event was implemented in the way to make
blink a standalone library:
   TRACE_EVENT macros
-> TRACE_EVENT internal macros
-> EventTracer
-> Chromium's trace event C++ API

Now blink is no longer a standalone library, so we can use chromium's
trace_event macros directly.

This CL
- removes blink's trace_event implementation
- lets blink's TraceEvent.h include chromium's trace_event.h,
- lets blink's TracedValue implement ConvertableToTraceFormat,
- keeps support of blink CString type as trace values.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-09-20 05:38:28]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 05:38:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 07:22:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 07:23:00]

Dry run: This issue passed the CQ dry run.

[Xianzhu, 2016-09-20 16:35:15]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-09-20 16:35:16]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2341333003/#ps60001
(title: "TraceEvent::toTraceTimestamp()")

[commit-bot: I haz the power, 2016-09-20 16:36:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 16:44:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 16:44:40]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Xianzhu, 2016-09-20 16:46:28]

wangxianzhu@chromium.org changed reviewers:
+ oysteine@chromium.org
- primiano@chromium.org

[Xianzhu, 2016-09-20 16:46:28]

oysterine@, can you ptal base/trace_event? Thanks.

[Xianzhu, 2016-09-20 16:47:34]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 16:47:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[esprehn, 2016-09-20 16:51:27]

lgtm

[oystein (OOO til 10th of July), 2016-09-20 18:11:18]

This is awesome, lgtm with a nit!

https://codereview.chromium.org/2341333003/diff/80001/base/trace_event/trace_...
File base/trace_event/trace_event.h (right):

https://codereview.chromium.org/2341333003/diff/80001/base/trace_event/trace_...
base/trace_event/trace_event.h:68: // |categoryAndName| doesn't need to be a
constant string.
nit: category_and_name

[Xianzhu, 2016-09-20 18:15:48]

https://codereview.chromium.org/2341333003/diff/80001/base/trace_event/trace_...
File base/trace_event/trace_event.h (right):

https://codereview.chromium.org/2341333003/diff/80001/base/trace_event/trace_...
base/trace_event/trace_event.h:68: // |categoryAndName| doesn't need to be a
constant string.
On 2016/09/20 18:11:17, oystein wrote:
> nit: category_and_name

Done.

[Xianzhu, 2016-09-20 18:16:19]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-09-20 18:16:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, oysteine@chromium.org, esprehn@chromium.org
Link to the patchset: https://codereview.chromium.org/2341333003/#ps100001
(title: "")

[commit-bot: I haz the power, 2016-09-20 18:17:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 19:51:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 19:51:20]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Xianzhu, 2016-09-20 20:36:24]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-09-20 20:37:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 23:50:04]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-09-20 23:52:37]

Description was changed from

==========
Use chromium trace_event implementation in blink

Previously blink's trace_event was implemented in the way to make
blink a standalone library:
   TRACE_EVENT macros
-> TRACE_EVENT internal macros
-> EventTracer
-> Chromium's trace event C++ API

Now blink is no longer a standalone library, so we can use chromium's
trace_event macros directly.

This CL
- removes blink's trace_event implementation
- lets blink's TraceEvent.h include chromium's trace_event.h,
- lets blink's TracedValue implement ConvertableToTraceFormat,
- keeps support of blink CString type as trace values.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Use chromium trace_event implementation in blink

Previously blink's trace_event was implemented in the way to make
blink a standalone library:
   TRACE_EVENT macros
-> TRACE_EVENT internal macros
-> EventTracer
-> Chromium's trace event C++ API

Now blink is no longer a standalone library, so we can use chromium's
trace_event macros directly.

This CL
- removes blink's trace_event implementation
- lets blink's TraceEvent.h include chromium's trace_event.h,
- lets blink's TracedValue implement ConvertableToTraceFormat,
- keeps support of blink CString type as trace values.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/f1acd2dd9f935f7d29dcee651f84eac16761609f
Cr-Commit-Position: refs/heads/master@{#419897}
==========

[commit-bot: I haz the power, 2016-09-20 23:52:38]

Patchset 6 (id:??) landed as
https://crrev.com/f1acd2dd9f935f7d29dcee651f84eac16761609f
Cr-Commit-Position: refs/heads/master@{#419897}