Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2345013002: Mojo C++ bindings: remove the lock in MultiplexRouter if it only serves a single interface. (Closed)

Created:
4 years, 3 months ago by yzshen1
Modified:
4 years, 3 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: remove the lock in MultiplexRouter if it only serves a single interface. BUG=594244 Committed: https://crrev.com/053dc1466340b8206ed42e1909e49d17712e51ee Cr-Commit-Position: refs/heads/master@{#419036}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -83 lines) Patch
M mojo/public/cpp/bindings/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/cpp/bindings/associated_interface_ptr.h View 1 chunk +3 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/lib/binding_state.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/connector.cc View 5 chunks +5 lines, -31 lines 0 comments Download
M mojo/public/cpp/bindings/lib/interface_ptr_state.h View 1 chunk +2 lines, -1 line 0 comments Download
A mojo/public/cpp/bindings/lib/may_auto_lock.h View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/lib/multiplex_router.h View 3 chunks +18 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/lib/multiplex_router.cc View 1 36 chunks +47 lines, -36 lines 0 comments Download
M mojo/public/cpp/bindings/tests/associated_interface_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/tests/bindings_perftest.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M mojo/public/cpp/bindings/tests/multiplex_router_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (10 generated)
yzshen1
Hi, Ken. Would you please take a look? Thanks!
4 years, 3 months ago (2016-09-15 19:47:11 UTC) #3
Ken Rockot(use gerrit already)
lgtm https://codereview.chromium.org/2345013002/diff/20001/mojo/public/cpp/bindings/lib/may_auto_lock.h File mojo/public/cpp/bindings/lib/may_auto_lock.h (right): https://codereview.chromium.org/2345013002/diff/20001/mojo/public/cpp/bindings/lib/may_auto_lock.h#newcode33 mojo/public/cpp/bindings/lib/may_auto_lock.h:33: // into nit: weird formatting
4 years, 3 months ago (2016-09-15 20:21:41 UTC) #5
yzshen1
Thanks, Ken! https://codereview.chromium.org/2345013002/diff/20001/mojo/public/cpp/bindings/lib/may_auto_lock.h File mojo/public/cpp/bindings/lib/may_auto_lock.h (right): https://codereview.chromium.org/2345013002/diff/20001/mojo/public/cpp/bindings/lib/may_auto_lock.h#newcode33 mojo/public/cpp/bindings/lib/may_auto_lock.h:33: // into On 2016/09/15 20:21:41, Ken Rockot ...
4 years, 3 months ago (2016-09-15 21:25:00 UTC) #8
commit-bot: I haz the power
This CL has an open dependency (Issue 2340363002 Patch 1). Please resolve the dependency and ...
4 years, 3 months ago (2016-09-15 21:25:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2345013002/40001
4 years, 3 months ago (2016-09-15 22:15:40 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-15 23:30:50 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 23:33:43 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/053dc1466340b8206ed42e1909e49d17712e51ee
Cr-Commit-Position: refs/heads/master@{#419036}

Powered by Google App Engine
This is Rietveld 408576698