mojo/public/cpp/bindings/lib/binding_state.cc - Issue 2345013002: Mojo C++ bindings: remove the lock in MultiplexRouter if it only serves a single interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/lib/binding_state.cc

Issue 2345013002: Mojo C++ bindings: remove the lock in MultiplexRouter if it only serves a single interface. (Closed)

Patch Set: . Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/cpp/bindings/lib/binding_state.cc

diff --git a/mojo/public/cpp/bindings/lib/binding_state.cc b/mojo/public/cpp/bindings/lib/binding_state.cc

index b63677e41714b86f5dd463e69b2f5839faf0aff6..c9462745906f0493fdc08f8f8f22f6939a93a2c1 100644

--- a/mojo/public/cpp/bindings/lib/binding_state.cc

+++ b/mojo/public/cpp/bindings/lib/binding_state.cc

@@ -146,7 +146,8 @@ void MultiplexedBindingState::BindInternal(

uint32_t interface_version) {

DCHECK(!router_);

- router_ = new internal::MultiplexRouter(false, std::move(handle), runner);

+ router_ = new MultiplexRouter(

+ std::move(handle), MultiplexRouter::MULTI_INTERFACE, false, runner);

router_->SetMasterInterfaceName(interface_name);

endpoint_client_.reset(new InterfaceEndpointClient(