Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Issue 2340363002: Mojo C++ bindings: add more perf tests for Router/MultiplexRouter. (Closed)

Created:
4 years, 3 months ago by yzshen1
Modified:
4 years, 3 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: add more perf tests for Router/MultiplexRouter. These new tests measure performance of dispatching incoming messages on the same thread. Currently on Linux: RouterDispatchCost 3.93483e+06 times/second MultiplexRouterDispatchCost 3.39754e+06 times/second BUG=594244 Committed: https://crrev.com/649f34f7c6195cdb40c5c451208baed00dd05084 Cr-Commit-Position: refs/heads/master@{#419007}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -24 lines) Patch
M mojo/public/cpp/bindings/lib/interface_endpoint_client.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/multiplex_router.h View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/lib/router.h View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/tests/bindings_perftest.cc View 5 chunks +105 lines, -23 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
yzshen1
Hi, Ken. Would you please take a look? Thanks!
4 years, 3 months ago (2016-09-15 17:32:43 UTC) #4
Ken Rockot(use gerrit already)
lgtm
4 years, 3 months ago (2016-09-15 20:06:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340363002/1
4 years, 3 months ago (2016-09-15 21:18:29 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 22:10:44 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 22:14:31 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/649f34f7c6195cdb40c5c451208baed00dd05084
Cr-Commit-Position: refs/heads/master@{#419007}

Powered by Google App Engine
This is Rietveld 408576698