mojo/public/cpp/bindings/lib/interface_ptr_state.h - Issue 2345013002: Mojo C++ bindings: remove the lock in MultiplexRouter if it only serves a single interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/lib/interface_ptr_state.h

Issue 2345013002: Mojo C++ bindings: remove the lock in MultiplexRouter if it only serves a single interface. (Closed)

Patch Set: . Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/cpp/bindings/lib/interface_ptr_state.h

diff --git a/mojo/public/cpp/bindings/lib/interface_ptr_state.h b/mojo/public/cpp/bindings/lib/interface_ptr_state.h

index 8fb8b068508cb2eada5c0ed145819f38864364b2..341901c56d372125336029be1f128e43decc0557 100644

--- a/mojo/public/cpp/bindings/lib/interface_ptr_state.h

+++ b/mojo/public/cpp/bindings/lib/interface_ptr_state.h

@@ -345,7 +345,8 @@ class InterfacePtrState<Interface, true> {

if (!handle_.is_valid())

return;

- router_ = new MultiplexRouter(true, std::move(handle_), runner_);

+ router_ = new MultiplexRouter(

+ std::move(handle_), MultiplexRouter::MULTI_INTERFACE, true, runner_);

router_->SetMasterInterfaceName(Interface::Name_);

endpoint_client_.reset(new InterfaceEndpointClient(

router_->CreateLocalEndpointHandle(kMasterInterfaceId), nullptr,