Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: Source/bindings/v8/ScriptPromise.h

Issue 23450039: Pass isolate to ScriptValue constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove useless member Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/ScriptPromise.h
diff --git a/Source/bindings/v8/ScriptPromise.h b/Source/bindings/v8/ScriptPromise.h
index 02f0a227b39aa701b9e539d8c07e953d79d9e451..ff7ca63ee96bbc200628db0619d0dca276ae71e9 100644
--- a/Source/bindings/v8/ScriptPromise.h
+++ b/Source/bindings/v8/ScriptPromise.h
@@ -57,7 +57,7 @@ public:
}
explicit ScriptPromise(v8::Handle<v8::Value> promise)
- : m_promise(promise)
+ : m_promise(promise, v8::Isolate::GetCurrent())
haraken 2013/09/16 16:39:53 Would it be possible to fix caller sites of Script
do-not-use 2013/09/16 20:28:05 I was planning to do this in a follow-up patch (di
do-not-use 2013/09/17 06:52:13 Added a FIXME comment for now.
{
ASSERT(!m_promise.hasNoValue());
}

Powered by Google App Engine
This is Rietveld 408576698