Source/bindings/v8/ScriptString.h - Issue 23450039: Pass isolate to ScriptValue constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/ScriptString.h

Issue 23450039: Pass isolate to ScriptValue constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Remove useless member Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/ScriptString.h

diff --git a/Source/bindings/v8/ScriptString.h b/Source/bindings/v8/ScriptString.h

index 14467c7eb9feb0e4c7780ef86d013820b5f2174f..6dcb68c5b5720618d7adaad3613a510af30db78f 100644

--- a/Source/bindings/v8/ScriptString.h

+++ b/Source/bindings/v8/ScriptString.h

@@ -40,7 +40,7 @@ namespace WebCore {

class ScriptString : public ScriptValue {

public:

ScriptString() { }

- explicit ScriptString(v8::Handle<v8::String> value) : ScriptValue(value) { }

+ explicit ScriptString(v8::Handle<v8::String> value) : ScriptValue(value, v8::Isolate::GetCurrent()) { }

haraken 2013/09/16 16:39:53 Ditto.

do-not-use 2013/09/17 06:52:13 Added a FIXME comment for now.

ScriptString concatenateWith(const String&);

String flattenToString() const;