Source/bindings/v8/CustomElementConstructorBuilder.cpp - Issue 23450039: Pass isolate to ScriptValue constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/CustomElementConstructorBuilder.cpp

Issue 23450039: Pass isolate to ScriptValue constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Remove useless member Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/CustomElementConstructorBuilder.cpp

diff --git a/Source/bindings/v8/CustomElementConstructorBuilder.cpp b/Source/bindings/v8/CustomElementConstructorBuilder.cpp

index 110f8829dea35d1c13145a232d5781e56700e613..010cf2a1962a3a7cc0792e6d9a70d98df261144a 100644

--- a/Source/bindings/v8/CustomElementConstructorBuilder.cpp

+++ b/Source/bindings/v8/CustomElementConstructorBuilder.cpp

@@ -232,7 +232,7 @@ bool CustomElementConstructorBuilder::didRegisterDefinition(CustomElementDefinit

ScriptValue CustomElementConstructorBuilder::bindingsReturnValue() const

{

- return ScriptValue(m_constructor);

+ return ScriptValue(m_constructor, v8::Isolate::GetCurrent());

haraken 2013/09/16 16:39:53 Can't you use m_context->GetIsolate() ?

do-not-use 2013/09/17 06:52:13 Done.

}

bool CustomElementConstructorBuilder::hasValidPrototypeChainFor(WrapperTypeInfo* type) const