Source/bindings/tests/results/V8TestSerializedScriptValueInterface.cpp - Issue 23450039: Pass isolate to ScriptValue constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestSerializedScriptValueInterface.cpp

Issue 23450039: Pass isolate to ScriptValue constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Remove useless member Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/V8TestObject.cpp ('k') | Source/bindings/v8/CustomElementConstructorBuilder.cpp » ('j') | Source/bindings/v8/CustomElementConstructorBuilder.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/V8TestSerializedScriptValueInterface.cpp

diff --git a/Source/bindings/tests/results/V8TestSerializedScriptValueInterface.cpp b/Source/bindings/tests/results/V8TestSerializedScriptValueInterface.cpp

index 60e0e59dcfe1d2f99d8bdbfe1f95eaa8b451d213..d1d3fcc854d27abbf17cdfad98cc93641924d478 100644

--- a/Source/bindings/tests/results/V8TestSerializedScriptValueInterface.cpp

+++ b/Source/bindings/tests/results/V8TestSerializedScriptValueInterface.cpp

@@ -175,7 +175,7 @@ static void dirtyScriptValueAttributeGetterCallback(v8::Local<v8::String> name,

static void dirtyScriptValueAttributeSetter(v8::Local<v8::String> name, v8::Local<v8::Value> value, const v8::PropertyCallbackInfo<void>& info)

{

TestSerializedScriptValueInterface* imp = V8TestSerializedScriptValueInterface::toNative(info.Holder());

- V8TRYCATCH_VOID(ScriptValue, v, ScriptValue(value));

+ V8TRYCATCH_VOID(ScriptValue, v, ScriptValue(value, info.GetIsolate()));

imp->setDirtyScriptValue(v);

info.Holder()->DeleteHiddenValue(v8::String::NewSymbol("dirtyScriptValue")); // Invalidate the cached value.

return;