DevTools: return discovered targets asynchronously.

DevTools: return discovered targets asynchronously.

BUG=627517
TBR= (interface changed)

Committed: https://crrev.com/e28eab4196fd3d2da875a39f89c3e83852ccd0af
Cr-Commit-Position: refs/heads/master@{#420189}

[pfeldman, 2016-09-15 00:20:27]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 00:21:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pfeldman, 2016-09-15 00:28:55]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[commit-bot: I haz the power, 2016-09-15 00:40:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 00:40:17]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[dgozman, 2016-09-15 03:25:11]

lgtm

https://codereview.chromium.org/2344753002/diff/40001/content/browser/devtool...
File content/browser/devtools/protocol/browser_handler.cc (right):

https://codereview.chromium.org/2344753002/diff/40001/content/browser/devtool...
content/browser/devtools/protocol/browser_handler.cc:97: const std::string&
targetId) {
target_id

https://codereview.chromium.org/2344753002/diff/40001/content/browser/devtool...
content/browser/devtools/protocol/browser_handler.cc:108:
DevToolsAgentHost::GetForId(targetId);
Should we look for one in the list instead? Otherwise it's unclear why we needed
to discover.

https://codereview.chromium.org/2344753002/diff/40001/content/browser/devtool...
content/browser/devtools/protocol/browser_handler.cc:127:
Response::ServerError("Target is not being debugged");
Let's make detach return success as well?

https://codereview.chromium.org/2344753002/diff/40001/content/browser/devtool...
File content/browser/devtools/protocol/browser_handler.h (right):

https://codereview.chromium.org/2344753002/diff/40001/content/browser/devtool...
content/browser/devtools/protocol/browser_handler.h:36: using TargetInfos =
std::vector<scoped_refptr<devtools::browser::TargetInfo>>;
Let's remove this one.

https://codereview.chromium.org/2344753002/diff/40001/content/browser/devtool...
content/browser/devtools/protocol/browser_handler.h:49: const std::string&
targetId);
target_id everywhere

[pfeldman, 2016-09-15 20:08:10]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-09-15 20:08:10]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2344753002/#ps60001
(title: "for landing")

[pfeldman, 2016-09-15 20:08:24]

all done.

[commit-bot: I haz the power, 2016-09-15 20:08:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 20:17:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 20:17:48]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pfeldman, 2016-09-15 20:20:30]

Description was changed from

==========
DevTools: return discovered targets asynchronously.

BUG=627517
==========

to

==========
DevTools: return discovered targets asynchronously.

BUG=627517
TBR= (interface changed)
==========

[pfeldman, 2016-09-15 20:20:35]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-09-15 20:20:35]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2344753002/#ps80001
(title: "for landing")

[commit-bot: I haz the power, 2016-09-15 20:21:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 21:53:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 21:53:38]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[pfeldman, 2016-09-15 21:55:08]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2016-09-15 21:55:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 22:56:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 22:56:19]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[nednguyen, 2016-09-17 00:08:53]

On 2016/09/15 22:56:19, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

To reproduce the failure locally, you can run:
./tools/perf/run_tests --browser=android-chromium --device=android
testWithSilkDetails

[pfeldman, 2016-09-21 00:04:01]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-09-21 00:04:01]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2344753002/#ps100001
(title: "rebaselined")

[commit-bot: I haz the power, 2016-09-21 00:04:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 01:27:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 01:27:32]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[pfeldman, 2016-09-21 21:29:36]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-09-21 21:29:37]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2344753002/#ps120001
(title: "for bots")

[commit-bot: I haz the power, 2016-09-21 21:30:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 23:01:18]

Description was changed from

==========
DevTools: return discovered targets asynchronously.

BUG=627517
TBR= (interface changed)
==========

to

==========
DevTools: return discovered targets asynchronously.

BUG=627517
TBR= (interface changed)
==========

[commit-bot: I haz the power, 2016-09-21 23:01:19]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-09-21 23:04:10]

Description was changed from

==========
DevTools: return discovered targets asynchronously.

BUG=627517
TBR= (interface changed)
==========

to

==========
DevTools: return discovered targets asynchronously.

BUG=627517
TBR= (interface changed)

Committed: https://crrev.com/e28eab4196fd3d2da875a39f89c3e83852ccd0af
Cr-Commit-Position: refs/heads/master@{#420189}
==========

[commit-bot: I haz the power, 2016-09-21 23:04:12]

Patchset 7 (id:??) landed as
https://crrev.com/e28eab4196fd3d2da875a39f89c3e83852ccd0af
Cr-Commit-Position: refs/heads/master@{#420189}