DevTools: return discovered targets asynchronously.

content/browser/devtools/devtools_http_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
 #include <utility>
 
@@ skipping 516 matching lines @@
     version.SetString("User-Agent", user_agent_);
 #if defined(OS_ANDROID)
     version.SetString("Android-Package",
         base::android::BuildInfo::GetInstance()->package_name());
 #endif
     SendJson(connection_id, net::HTTP_OK, &version, std::string());
     return;
   }
 
   if (command == "list") {
-    std::string host = info.headers["host"];
-    DevToolsAgentHost::List agent_hosts =
-        DevToolsAgentHost::DiscoverAllHosts();
-    std::sort(agent_hosts.begin(), agent_hosts.end(), TimeComparator);
-    agent_host_map_.clear();
-    base::ListValue list_value;
-    for (auto& agent_host : agent_hosts) {
-      agent_host_map_[agent_host->GetId()] = agent_host;
-      list_value.Append(SerializeDescriptor(agent_host, host));
-    }
-    SendJson(connection_id, net::HTTP_OK, &list_value, std::string());
+    DevToolsAgentHost::DiscoverAllHosts(
+        base::Bind(&DevToolsHttpHandler::RespondToJsonList,
+                   weak_factory_.GetWeakPtr(), connection_id,
+                   info.headers["host"]));
     return;
   }
 
   if (command == "new") {
     GURL url(net::UnescapeURLComponent(
         query, net::UnescapeRule::URL_SPECIAL_CHARS_EXCEPT_PATH_SEPARATORS |
                    net::UnescapeRule::PATH_SEPARATORS));
     if (!url.is_valid())
       url = GURL(url::kAboutBlankURL);
     scoped_refptr<DevToolsAgentHost> agent_host = nullptr;
@@ skipping 48 matching lines @@
       return;
     }
   }
   SendJson(connection_id,
            net::HTTP_NOT_FOUND,
            NULL,
            "Unknown command: " + command);
   return;
 }
 
+void DevToolsHttpHandler::RespondToJsonList(
+    int connection_id,
+    const std::string& host,
+    DevToolsAgentHost::List hosts) {
+  DevToolsAgentHost::List agent_hosts = std::move(hosts);
+  std::sort(agent_hosts.begin(), agent_hosts.end(), TimeComparator);
+  agent_host_map_.clear();
+  base::ListValue list_value;
+  for (auto& agent_host : agent_hosts) {
+    agent_host_map_[agent_host->GetId()] = agent_host;
+    list_value.Append(SerializeDescriptor(agent_host, host));
+  }
+  SendJson(connection_id, net::HTTP_OK, &list_value, std::string());
+}
+
 scoped_refptr<DevToolsAgentHost> DevToolsHttpHandler::GetAgentHost(
     const std::string& target_id) {
   DescriptorMap::const_iterator it = agent_host_map_.find(target_id);
   return it != agent_host_map_.end() ? it->second : nullptr;
 }
 
 void DevToolsHttpHandler::OnDiscoveryPageRequest(int connection_id) {
   std::string response = delegate_->GetDiscoveryPageHTML();
   Send200(connection_id, response, "text/html; charset=UTF-8");
 }
@@ skipping 226 matching lines @@
         id.c_str(),
         host);
     dictionary->SetString(
         kTargetDevtoolsFrontendUrlField, devtools_frontend_url);
   }
 
   return dictionary;
 }
 
 }  // namespace content