DevTools: return discovered targets asynchronously.

chrome/browser/android/devtools_manager_delegate_android.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/devtools_manager_delegate_android.h"
 
 #include "base/bind.h"
 #include "base/memory/ptr_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 141 matching lines @@
   }
 
   const int tab_id_;
   const std::string title_;
   const GURL url_;
   scoped_refptr<DevToolsAgentHost> agent_host_;
   content::DevToolsExternalAgentProxy* proxy_;
   DISALLOW_COPY_AND_ASSIGN(TabProxyDelegate);
 };
 
-DevToolsAgentHost::List GetDescriptors() {
-  DevToolsAgentHost::List result;
-
-  // Enumerate existing tabs, including the ones with no WebContents.
-  std::set<WebContents*> tab_web_contents;
-  for (TabModelList::const_iterator iter = TabModelList::begin();
-      iter != TabModelList::end(); ++iter) {
-    TabModel* model = *iter;
-    for (int i = 0; i < model->GetTabCount(); ++i) {
-      TabAndroid* tab = model->GetTabAt(i);
-      if (!tab)
-        continue;
-
-      if (tab->web_contents())
-        tab_web_contents.insert(tab->web_contents());
-
-      scoped_refptr<DevToolsAgentHost> host =
-          DevToolsAgentHost::Forward(
-              base::IntToString(tab->GetAndroidId()),
-              base::WrapUnique(new TabProxyDelegate(tab)));
-      result.push_back(host);
-    }
-  }
-
-  // Add descriptors for targets not associated with any tabs.
-  DevToolsAgentHost::List agents = DevToolsAgentHost::GetOrCreateAll();
-  for (DevToolsAgentHost::List::iterator it = agents.begin();
-       it != agents.end(); ++it) {
-    if (WebContents* web_contents = (*it)->GetWebContents()) {
-      if (tab_web_contents.find(web_contents) != tab_web_contents.end())
-        continue;
-    }
-    result.push_back(*it);
-  }
-
-  return result;
-}
-
 } //  namespace
 
 DevToolsManagerDelegateAndroid::DevToolsManagerDelegateAndroid()
     : network_protocol_handler_(new DevToolsNetworkProtocolHandler()) {
-#if BUILDFLAG(ANDROID_JAVA_UI)
-  DevToolsAgentHost::AddDiscoveryProvider(base::Bind(&GetDescriptors));
-#endif  // BUILDFLAG(ANDROID_JAVA_UI)
 }
 
 DevToolsManagerDelegateAndroid::~DevToolsManagerDelegateAndroid() {
 }
 
 void DevToolsManagerDelegateAndroid::Inspect(
     DevToolsAgentHost* agent_host) {
 }
 
 base::DictionaryValue* DevToolsManagerDelegateAndroid::HandleCommand(
@@ skipping 13 matching lines @@
 }
 
 std::string DevToolsManagerDelegateAndroid::GetTargetTitle(
     content::RenderFrameHost* host) {
   content::WebContents* web_contents =
       content::WebContents::FromRenderFrameHost(host);
   TabAndroid* tab = TabAndroid::FromWebContents(web_contents);
   return tab ? base::UTF16ToUTF8(tab->GetTitle()) : "";
 }
 
+bool DevToolsManagerDelegateAndroid::DiscoverTargets(
+      const DevToolsAgentHost::DiscoveryCallback& callback) {
+#if BUILDFLAG(ANDROID_JAVA_UI)
+  // Enumerate existing tabs, including the ones with no WebContents.
+  DevToolsAgentHost::List result;
+  std::set<WebContents*> tab_web_contents;
+  for (TabModelList::const_iterator iter = TabModelList::begin();
+      iter != TabModelList::end(); ++iter) {
+    TabModel* model = *iter;
+    for (int i = 0; i < model->GetTabCount(); ++i) {
+      TabAndroid* tab = model->GetTabAt(i);
+      if (!tab)
+        continue;
+
+      if (tab->web_contents())
+        tab_web_contents.insert(tab->web_contents());
+
+      scoped_refptr<DevToolsAgentHost> host =
+          DevToolsAgentHost::Forward(
+              base::IntToString(tab->GetAndroidId()),
+              base::WrapUnique(new TabProxyDelegate(tab)));
+      result.push_back(host);
+    }
+  }
+
+  // Add descriptors for targets not associated with any tabs.
+  DevToolsAgentHost::List agents = DevToolsAgentHost::GetOrCreateAll();
+  for (DevToolsAgentHost::List::iterator it = agents.begin();
+       it != agents.end(); ++it) {
+    if (WebContents* web_contents = (*it)->GetWebContents()) {
+      if (tab_web_contents.find(web_contents) != tab_web_contents.end())
+        continue;
+    }
+    result.push_back(*it);
+  }
+
+  callback.Run(std::move(result));
+  return true;
+#else
+  return false;
+#endif  // BUILDFLAG(ANDROID_JAVA_UI)
+}
+
 scoped_refptr<DevToolsAgentHost>
 DevToolsManagerDelegateAndroid::CreateNewTarget(const GURL& url) {
   if (TabModelList::empty())
     return nullptr;
 
   TabModel* tab_model = TabModelList::get(0);
   if (!tab_model)
     return nullptr;
 
   WebContents* web_contents = tab_model->CreateNewTabForDevTools(url);
@@ skipping 11 matching lines @@
 
 std::string DevToolsManagerDelegateAndroid::GetDiscoveryPageHTML() {
   return ResourceBundle::GetSharedInstance().GetRawDataResource(
       IDR_DEVTOOLS_DISCOVERY_PAGE_HTML).as_string();
 }
 
 void DevToolsManagerDelegateAndroid::DevToolsAgentStateChanged(
     DevToolsAgentHost* agent_host, bool attached) {
   network_protocol_handler_->DevToolsAgentStateChanged(agent_host, attached);
 }