Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: content/public/browser/devtools_manager_delegate.h

Issue 2344753002: DevTools: return discovered targets asynchronously. (Closed)
Patch Set: for bots Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/browser/devtools_agent_host.h ('k') | content/public/browser/devtools_manager_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/devtools_manager_delegate.h
diff --git a/content/public/browser/devtools_manager_delegate.h b/content/public/browser/devtools_manager_delegate.h
index 6ac50e3380c1ba548bd0883fe6036b90c7f0a888..165b2337ebf6f3aa2293e9ca97ccf0ad4b77545d 100644
--- a/content/public/browser/devtools_manager_delegate.h
+++ b/content/public/browser/devtools_manager_delegate.h
@@ -8,6 +8,7 @@
#include <string>
#include "base/memory/ref_counted.h"
#include "content/common/content_export.h"
+#include "content/public/browser/devtools_agent_host.h"
#include "url/gurl.h"
namespace base {
@@ -17,7 +18,6 @@ class DictionaryValue;
namespace content {
class BrowserContext;
-class DevToolsAgentHost;
class RenderFrameHost;
class CONTENT_EXPORT DevToolsManagerDelegate {
@@ -37,6 +37,12 @@ class CONTENT_EXPORT DevToolsManagerDelegate {
// Returns DevToolsAgentHost title to use for given |host| target.
virtual std::string GetTargetDescription(RenderFrameHost* host);
+ // Returns all targets embedder would like to report as discoverable.
+ // If returns false, all targets content is aware of and only those
+ // should be discoverable.
+ virtual bool DiscoverTargets(
+ const DevToolsAgentHost::DiscoveryCallback& callback);
+
// Creates new inspectable target given the |url|.
virtual scoped_refptr<DevToolsAgentHost> CreateNewTarget(const GURL& url);
« no previous file with comments | « content/public/browser/devtools_agent_host.h ('k') | content/public/browser/devtools_manager_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698