Reland of Enable whitelisting for targets other than libchrome.

Reland of Enable whitelisting for targets other than libchrome.

Reverted in:
https://codereview.chromium.org/2348643002/

Reason for revert:
Fixed gn gen errror

This will allow monochrome to easily define its own set of the same
targets with a different resource whitelist

TBR=brettw@chromium.org,miu@chromium.org
BUG=641032
Committed: https://crrev.com/26cf65711c693aac13c897b67d0e138c3ee42ece
Cr-Commit-Position: refs/heads/master@{#419074}

[agrieve, 2016-09-16 00:17:26]

Created Reland of Enable whitelisting for targets other than libchrome.

[agrieve, 2016-09-16 00:20:11]

Description was changed from

==========
Reland of Enable whitelisting for targets other than libchrome. (patchset #1
id:1 of https://codereview.chromium.org/2348643002/ )

Reason for revert:
Will update when fixed

Original issue's description:
> Revert of Enable whitelisting for targets other than libchrome. (patchset #8
id:40002 of https://codereview.chromium.org/2336033002/ )
> 
> Reason for revert:
> Broke ninja on Linux x64:
> 
> ninja: Entering directory `out/Release'
> [1/1] Regenerating ninja files
> FAILED: build.ninja
> /mnt/ssd/miu/chromium/src/buildtools/linux64/gn
--root=/mnt/ssd/miu/chromium/src -q gen //out/Release/
> ERROR at //chrome/BUILD.gn:1358:5: Undefined identifier.
>     public_deps += [ ":default_apps" ]
>     ^----------
> See //BUILD.gn:211:7: which caused the file to be included.
>       "//chrome",
>       ^---------
> ninja: error: rebuilding 'build.ninja': subcommand failed
> 
> Original issue's description:
> > Refactor chrome resource targets into chrome_paks.gni
> >
> > This will allow monochrome to easily define its own set of the same
> > targets with a different resource whitelist
> >
> > BUG=641032
> >
> > Committed: https://crrev.com/33312c3d3dc09f27325e74644b346123b325891e
> > Cr-Commit-Position: refs/heads/master@{#418966}
> 
> TBR=brettw@chromium.org,agrieve@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=641032
> 
> Committed: https://crrev.com/be4eedd9735c6daf3c30709e10e14f17b955a886
> Cr-Commit-Position: refs/heads/master@{#418992}

TBR=brettw@chromium.org,miu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=641032
==========

to

==========
Reland of Enable whitelisting for targets other than libchrome.

Reverted in:
https://codereview.chromium.org/2348643002/

Reason for revert:
Fixed gn gen errror

This will allow monochrome to easily define its own set of the same
targets with a different resource whitelist

TBR=brettw@chromium.org,miu@chromium.org
BUG=641032
==========

[agrieve, 2016-09-16 00:21:29]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-09-16 00:21:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 01:48:35]

Description was changed from

==========
Reland of Enable whitelisting for targets other than libchrome.

Reverted in:
https://codereview.chromium.org/2348643002/

Reason for revert:
Fixed gn gen errror

This will allow monochrome to easily define its own set of the same
targets with a different resource whitelist

TBR=brettw@chromium.org,miu@chromium.org
BUG=641032
==========

to

==========
Reland of Enable whitelisting for targets other than libchrome.

Reverted in:
https://codereview.chromium.org/2348643002/

Reason for revert:
Fixed gn gen errror

This will allow monochrome to easily define its own set of the same
targets with a different resource whitelist

TBR=brettw@chromium.org,miu@chromium.org
BUG=641032
==========

[commit-bot: I haz the power, 2016-09-16 01:48:36]

Committed patchset #2 (id:90001)

[commit-bot: I haz the power, 2016-09-16 01:51:12]

Description was changed from

==========
Reland of Enable whitelisting for targets other than libchrome.

Reverted in:
https://codereview.chromium.org/2348643002/

Reason for revert:
Fixed gn gen errror

This will allow monochrome to easily define its own set of the same
targets with a different resource whitelist

TBR=brettw@chromium.org,miu@chromium.org
BUG=641032
==========

to

==========
Reland of Enable whitelisting for targets other than libchrome.

Reverted in:
https://codereview.chromium.org/2348643002/

Reason for revert:
Fixed gn gen errror

This will allow monochrome to easily define its own set of the same
targets with a different resource whitelist

TBR=brettw@chromium.org,miu@chromium.org
BUG=641032

Committed: https://crrev.com/26cf65711c693aac13c897b67d0e138c3ee42ece
Cr-Commit-Position: refs/heads/master@{#419074}
==========

[commit-bot: I haz the power, 2016-09-16 01:51:14]

Patchset 2 (id:??) landed as
https://crrev.com/26cf65711c693aac13c897b67d0e138c3ee42ece
Cr-Commit-Position: refs/heads/master@{#419074}

[Yuta Kitamura, 2016-09-16 04:25:32]

A revert of this CL (patchset #2 id:90001) has been created in
https://codereview.chromium.org/2342243003/ by yutak@chromium.org.

The reason for reverting is: Still causing GN errors on Google Chrome bots
(Win, Linux, and ChromeOS).

https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/b...

C:\b\c\b\win_chrome\src\buildtools\win\gn.exe gen //out/Release --check
  -> returned 1
ERROR at //chrome/BUILD.gn:1358:19: Assignment had no effect.
    public_deps = [
                  ^
You set the variable "public_deps" here and it was unused before it went
out of scope.
See //BUILD.gn:211:7: which caused the file to be included.
      "//chrome",
      ^---------
GN gen failed: 1
step returned non-zero exit code: 1.

[xdai1, 2016-09-16 05:50:22]

FYI: It also caused all the chrome information builders[1] fail, see
https://bugs.chromium.org/p/chromium/issues/detail?id=647488 for error message.
After the revert, the informational builders started to cycle green.

[1] example builder:
https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/x86-alex-tot-...
and you can find the log here:
https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/x86-alex-tot-...