Rename HTTP bad-related flags to be more clear

Rename HTTP bad-related flags to be more clear

The previous names used "non-secure", which is precise and correct
(anything that is not a secure context) but confusing (does that include
a supposedly secure context that is invalid?). This renames them to say
"Http", but leaves the actual name of the flag the same because it's
already widely documented.

BUG=646221
Committed: https://crrev.com/ddc621c75ee7aba48a886d48201052047212b780
Cr-Commit-Position: refs/heads/master@{#420780}

[felt, 2016-09-16 16:06:22]

The CQ bit was checked by felt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 16:06:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[felt, 2016-09-16 16:12:02]

Patchset #2 (id:20001) has been deleted

[felt, 2016-09-16 16:12:11]

Description was changed from

==========
Rename HTTP bad-related flags to be more clear

The previous names used "non-secure", which is precise and correct
(anything that is not a secure context) but confusing (does that include
a supposedly secure context that is invalid?). This renames them to say
"Http", but leaves the actual name of the flag the same because it's
already widely documented.

BUG=646221
==========

to

==========
Rename HTTP bad-related flags to be more clear

The previous names used "non-secure", which is precise and correct
(anything that is not a secure context) but confusing (does that include
a supposedly secure context that is invalid?). This renames them to say
"Http", but leaves the actual name of the flag the same because it's
already widely documented.

BUG=646221
==========

[felt, 2016-09-16 16:12:11]

felt@chromium.org changed reviewers:
+ lgarron@chromium.org

[felt, 2016-09-16 16:12:18]

lgarron, wdyt? better?

[felt, 2016-09-21 04:43:44]

ping to lgarron, i did this specifically because you asked :)

[felt, 2016-09-22 23:42:26]

felt@chromium.org changed reviewers:
+ estark@chromium.org

[felt, 2016-09-22 23:42:33]

estark, WDYT?

[lgarron, 2016-09-22 23:43:49]

On 2016/09/22 at 23:42:33, felt wrote:
> estark, WDYT?

Wooops, I missed this. LGTM, I appreciate the improved accuracy. :-)

[estark, 2016-09-22 23:53:53]

lgtm

This is a somewhat systematic problem though. :( I'm pretty sure there are other
places where we use nonsecure to mean "http", and also places where we use
"insecure" to mean "http" (as in "insecure content" instead of "mixed content"),
and also probably places where we used insecure to mean http-or-broken-https.
Boo.

https://codereview.chromium.org/2344043003/diff/40001/components/security_sta...
File components/security_state/security_state_model.cc (right):

https://codereview.chromium.org/2344043003/diff/40001/components/security_sta...
components/security_state/security_state_model.cc:28: enum MarkHttpStatus {
NEUTRAL, DUBIOUS, NON_SECURE, LAST_STATUS };
Just a heads-up, I think this will either conflict with or apply weirdly on top
of https://codereview.chromium.org/2350273002. So even if the rebase goes
through cleanly, you might want to just double-check that it doesn't come out as
something weird. (Like two enums, one named MarkHttpStatus and the other named
MarkHttpAsStatus, which is I think what I added.)

[felt, 2016-09-23 20:12:59]

The CQ bit was checked by felt@chromium.org

[felt, 2016-09-23 20:13:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
lgarron@chromium.org, estark@chromium.org
Link to the patchset: https://codereview.chromium.org/2344043003/#ps80001
(title: "Fix rebase errors")

[commit-bot: I haz the power, 2016-09-23 20:13:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 20:27:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 20:27:12]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[felt, 2016-09-23 22:00:52]

The CQ bit was checked by felt@chromium.org

[felt, 2016-09-23 22:00:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
lgarron@chromium.org, estark@chromium.org
Link to the patchset: https://codereview.chromium.org/2344043003/#ps100001
(title: "Missed a file")

[commit-bot: I haz the power, 2016-09-23 22:01:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 22:11:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 22:11:33]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[felt, 2016-09-23 22:15:26]

The CQ bit was checked by felt@chromium.org

[felt, 2016-09-23 22:15:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
lgarron@chromium.org, estark@chromium.org
Link to the patchset: https://codereview.chromium.org/2344043003/#ps120001
(title: "sfijdf")

[commit-bot: I haz the power, 2016-09-23 22:16:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 23:23:27]

Description was changed from

==========
Rename HTTP bad-related flags to be more clear

The previous names used "non-secure", which is precise and correct
(anything that is not a secure context) but confusing (does that include
a supposedly secure context that is invalid?). This renames them to say
"Http", but leaves the actual name of the flag the same because it's
already widely documented.

BUG=646221
==========

to

==========
Rename HTTP bad-related flags to be more clear

The previous names used "non-secure", which is precise and correct
(anything that is not a secure context) but confusing (does that include
a supposedly secure context that is invalid?). This renames them to say
"Http", but leaves the actual name of the flag the same because it's
already widely documented.

BUG=646221
==========

[commit-bot: I haz the power, 2016-09-23 23:23:29]

Committed patchset #6 (id:120001)

[commit-bot: I haz the power, 2016-09-23 23:27:09]

Description was changed from

==========
Rename HTTP bad-related flags to be more clear

The previous names used "non-secure", which is precise and correct
(anything that is not a secure context) but confusing (does that include
a supposedly secure context that is invalid?). This renames them to say
"Http", but leaves the actual name of the flag the same because it's
already widely documented.

BUG=646221
==========

to

==========
Rename HTTP bad-related flags to be more clear

The previous names used "non-secure", which is precise and correct
(anything that is not a secure context) but confusing (does that include
a supposedly secure context that is invalid?). This renames them to say
"Http", but leaves the actual name of the flag the same because it's
already widely documented.

BUG=646221

Committed: https://crrev.com/ddc621c75ee7aba48a886d48201052047212b780
Cr-Commit-Position: refs/heads/master@{#420780}
==========

[commit-bot: I haz the power, 2016-09-23 23:27:10]

Patchset 6 (id:??) landed as
https://crrev.com/ddc621c75ee7aba48a886d48201052047212b780
Cr-Commit-Position: refs/heads/master@{#420780}