Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1504)

Unified Diff: chrome/browser/about_flags.cc

Issue 2344043003: Rename HTTP bad-related flags to be more clear (Closed)
Patch Set: sfijdf Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/ssl/ssl_browser_tests.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 93ba859752a545fa3b9824260dc3cd61ffbaabba..65bfe93c729a99c41b46cb1a45e57c5d8e1764b1 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -195,16 +195,15 @@ const FeatureEntry::Choice kPassiveListenersChoices[] = {
switches::kPassiveListenersDefault, "forcealltrue"},
};
-const FeatureEntry::Choice kMarkNonSecureAsChoices[] = {
+const FeatureEntry::Choice kMarkHttpAsChoices[] = {
{IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", ""},
- {IDS_MARK_NON_SECURE_AS_NEUTRAL, security_state::switches::kMarkNonSecureAs,
- security_state::switches::kMarkNonSecureAsNeutral},
- {IDS_MARK_NON_SECURE_AS_NON_SECURE,
- security_state::switches::kMarkNonSecureAs,
- security_state::switches::kMarkNonSecureAsNonSecure},
- {IDS_MARK_NON_SECURE_WITH_PASSWORDS_OR_CC_AS_NON_SECURE,
- security_state::switches::kMarkNonSecureAs,
- security_state::switches::kMarkNonSecureWithPasswordsOrCcAsNonSecure}};
+ {IDS_MARK_HTTP_AS_NEUTRAL, security_state::switches::kMarkHttpAs,
+ security_state::switches::kMarkHttpAsNeutral},
+ {IDS_MARK_HTTP_AS_DANGEROUS, security_state::switches::kMarkHttpAs,
+ security_state::switches::kMarkHttpAsDangerous},
+ {IDS_MARK_HTTP_WITH_PASSWORDS_OR_CC_WITH_CHIP,
+ security_state::switches::kMarkHttpAs,
+ security_state::switches::kMarkHttpWithPasswordsOrCcWithChip}};
const FeatureEntry::Choice kDataReductionProxyLoFiChoices[] = {
{ IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
@@ -1533,9 +1532,8 @@ const FeatureEntry kFeatureEntries[] = {
IDS_FLAGS_EXPERIMENTAL_SECURITY_FEATURES_DESCRIPTION, kOsAll,
SINGLE_VALUE_TYPE(switches::kEnablePotentiallyAnnoyingSecurityFeatures)},
#endif
- {"mark-non-secure-as", IDS_MARK_NON_SECURE_AS_NAME,
- IDS_MARK_NON_SECURE_AS_DESCRIPTION, kOsAll,
- MULTI_VALUE_TYPE(kMarkNonSecureAsChoices)},
+ {"mark-non-secure-as", IDS_MARK_HTTP_AS_NAME, IDS_MARK_HTTP_AS_DESCRIPTION,
+ kOsAll, MULTI_VALUE_TYPE(kMarkHttpAsChoices)},
{"enable-site-per-process", IDS_FLAGS_SITE_PER_PROCESS_NAME,
IDS_FLAGS_SITE_PER_PROCESS_DESCRIPTION, kOsAll,
SINGLE_VALUE_TYPE(switches::kSitePerProcess)},
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/ssl/ssl_browser_tests.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698