Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2344043003: Rename HTTP bad-related flags to be more clear (Closed)
Patch Set: sfijdf Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/ssl/ssl_browser_tests.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 177 matching lines...) Expand 10 before | Expand all | Expand 10 after
188 #endif 188 #endif
189 189
190 const FeatureEntry::Choice kPassiveListenersChoices[] = { 190 const FeatureEntry::Choice kPassiveListenersChoices[] = {
191 {IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", ""}, 191 {IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", ""},
192 {IDS_FLAGS_PASSIVE_EVENT_LISTENER_TRUE, switches::kPassiveListenersDefault, 192 {IDS_FLAGS_PASSIVE_EVENT_LISTENER_TRUE, switches::kPassiveListenersDefault,
193 "true"}, 193 "true"},
194 {IDS_FLAGS_PASSIVE_EVENT_LISTENER_FORCE_ALL_TRUE, 194 {IDS_FLAGS_PASSIVE_EVENT_LISTENER_FORCE_ALL_TRUE,
195 switches::kPassiveListenersDefault, "forcealltrue"}, 195 switches::kPassiveListenersDefault, "forcealltrue"},
196 }; 196 };
197 197
198 const FeatureEntry::Choice kMarkNonSecureAsChoices[] = { 198 const FeatureEntry::Choice kMarkHttpAsChoices[] = {
199 {IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", ""}, 199 {IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", ""},
200 {IDS_MARK_NON_SECURE_AS_NEUTRAL, security_state::switches::kMarkNonSecureAs, 200 {IDS_MARK_HTTP_AS_NEUTRAL, security_state::switches::kMarkHttpAs,
201 security_state::switches::kMarkNonSecureAsNeutral}, 201 security_state::switches::kMarkHttpAsNeutral},
202 {IDS_MARK_NON_SECURE_AS_NON_SECURE, 202 {IDS_MARK_HTTP_AS_DANGEROUS, security_state::switches::kMarkHttpAs,
203 security_state::switches::kMarkNonSecureAs, 203 security_state::switches::kMarkHttpAsDangerous},
204 security_state::switches::kMarkNonSecureAsNonSecure}, 204 {IDS_MARK_HTTP_WITH_PASSWORDS_OR_CC_WITH_CHIP,
205 {IDS_MARK_NON_SECURE_WITH_PASSWORDS_OR_CC_AS_NON_SECURE, 205 security_state::switches::kMarkHttpAs,
206 security_state::switches::kMarkNonSecureAs, 206 security_state::switches::kMarkHttpWithPasswordsOrCcWithChip}};
207 security_state::switches::kMarkNonSecureWithPasswordsOrCcAsNonSecure}};
208 207
209 const FeatureEntry::Choice kDataReductionProxyLoFiChoices[] = { 208 const FeatureEntry::Choice kDataReductionProxyLoFiChoices[] = {
210 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" }, 209 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
211 { IDS_FLAGS_DATA_REDUCTION_PROXY_LO_FI_ALWAYS_ON, 210 { IDS_FLAGS_DATA_REDUCTION_PROXY_LO_FI_ALWAYS_ON,
212 data_reduction_proxy::switches::kDataReductionProxyLoFi, 211 data_reduction_proxy::switches::kDataReductionProxyLoFi,
213 data_reduction_proxy::switches::kDataReductionProxyLoFiValueAlwaysOn}, 212 data_reduction_proxy::switches::kDataReductionProxyLoFiValueAlwaysOn},
214 { IDS_FLAGS_DATA_REDUCTION_PROXY_LO_FI_CELLULAR_ONLY, 213 { IDS_FLAGS_DATA_REDUCTION_PROXY_LO_FI_CELLULAR_ONLY,
215 data_reduction_proxy::switches::kDataReductionProxyLoFi, 214 data_reduction_proxy::switches::kDataReductionProxyLoFi,
216 data_reduction_proxy::switches:: 215 data_reduction_proxy::switches::
217 kDataReductionProxyLoFiValueCellularOnly}, 216 kDataReductionProxyLoFiValueCellularOnly},
(...skipping 1308 matching lines...) Expand 10 before | Expand all | Expand 10 after
1526 SINGLE_VALUE_TYPE("enable-touch-hover")}, 1525 SINGLE_VALUE_TYPE("enable-touch-hover")},
1527 #if defined(OS_CHROMEOS) 1526 #if defined(OS_CHROMEOS)
1528 {"enable-wifi-credential-sync", IDS_FLAGS_WIFI_CREDENTIAL_SYNC_NAME, 1527 {"enable-wifi-credential-sync", IDS_FLAGS_WIFI_CREDENTIAL_SYNC_NAME,
1529 IDS_FLAGS_WIFI_CREDENTIAL_SYNC_DESCRIPTION, kOsCrOS, 1528 IDS_FLAGS_WIFI_CREDENTIAL_SYNC_DESCRIPTION, kOsCrOS,
1530 SINGLE_VALUE_TYPE(switches::kEnableWifiCredentialSync)}, 1529 SINGLE_VALUE_TYPE(switches::kEnableWifiCredentialSync)},
1531 {"enable-potentially-annoying-security-features", 1530 {"enable-potentially-annoying-security-features",
1532 IDS_FLAGS_EXPERIMENTAL_SECURITY_FEATURES_NAME, 1531 IDS_FLAGS_EXPERIMENTAL_SECURITY_FEATURES_NAME,
1533 IDS_FLAGS_EXPERIMENTAL_SECURITY_FEATURES_DESCRIPTION, kOsAll, 1532 IDS_FLAGS_EXPERIMENTAL_SECURITY_FEATURES_DESCRIPTION, kOsAll,
1534 SINGLE_VALUE_TYPE(switches::kEnablePotentiallyAnnoyingSecurityFeatures)}, 1533 SINGLE_VALUE_TYPE(switches::kEnablePotentiallyAnnoyingSecurityFeatures)},
1535 #endif 1534 #endif
1536 {"mark-non-secure-as", IDS_MARK_NON_SECURE_AS_NAME, 1535 {"mark-non-secure-as", IDS_MARK_HTTP_AS_NAME, IDS_MARK_HTTP_AS_DESCRIPTION,
1537 IDS_MARK_NON_SECURE_AS_DESCRIPTION, kOsAll, 1536 kOsAll, MULTI_VALUE_TYPE(kMarkHttpAsChoices)},
1538 MULTI_VALUE_TYPE(kMarkNonSecureAsChoices)},
1539 {"enable-site-per-process", IDS_FLAGS_SITE_PER_PROCESS_NAME, 1537 {"enable-site-per-process", IDS_FLAGS_SITE_PER_PROCESS_NAME,
1540 IDS_FLAGS_SITE_PER_PROCESS_DESCRIPTION, kOsAll, 1538 IDS_FLAGS_SITE_PER_PROCESS_DESCRIPTION, kOsAll,
1541 SINGLE_VALUE_TYPE(switches::kSitePerProcess)}, 1539 SINGLE_VALUE_TYPE(switches::kSitePerProcess)},
1542 {"enable-top-document-isolation", IDS_FLAGS_TOP_DOCUMENT_ISOLATION_NAME, 1540 {"enable-top-document-isolation", IDS_FLAGS_TOP_DOCUMENT_ISOLATION_NAME,
1543 IDS_FLAGS_TOP_DOCUMENT_ISOLATION_DESCRIPTION, kOsAll, 1541 IDS_FLAGS_TOP_DOCUMENT_ISOLATION_DESCRIPTION, kOsAll,
1544 SINGLE_VALUE_TYPE(switches::kTopDocumentIsolation)}, 1542 SINGLE_VALUE_TYPE(switches::kTopDocumentIsolation)},
1545 {"enable-use-zoom-for-dsf", IDS_FLAGS_ENABLE_USE_ZOOM_FOR_DSF_NAME, 1543 {"enable-use-zoom-for-dsf", IDS_FLAGS_ENABLE_USE_ZOOM_FOR_DSF_NAME,
1546 IDS_FLAGS_ENABLE_USE_ZOOM_FOR_DSF_DESCRIPTION, kOsAll, 1544 IDS_FLAGS_ENABLE_USE_ZOOM_FOR_DSF_DESCRIPTION, kOsAll,
1547 MULTI_VALUE_TYPE(kEnableUseZoomForDSFChoices)}, 1545 MULTI_VALUE_TYPE(kEnableUseZoomForDSFChoices)},
1548 #if defined(OS_MACOSX) 1546 #if defined(OS_MACOSX)
(...skipping 754 matching lines...) Expand 10 before | Expand all | Expand 10 after
2303 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2301 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2304 2302
2305 const FeatureEntry* GetFeatureEntries(size_t* count) { 2303 const FeatureEntry* GetFeatureEntries(size_t* count) {
2306 *count = arraysize(kFeatureEntries); 2304 *count = arraysize(kFeatureEntries);
2307 return kFeatureEntries; 2305 return kFeatureEntries;
2308 } 2306 }
2309 2307
2310 } // namespace testing 2308 } // namespace testing
2311 2309
2312 } // namespace about_flags 2310 } // namespace about_flags
OLDNEW
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/ssl/ssl_browser_tests.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698