Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Side by Side Diff: chrome/browser/ssl/ssl_browser_tests.cc

Issue 2344043003: Rename HTTP bad-related flags to be more clear (Closed)
Patch Set: sfijdf Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | components/security_state/security_state_model.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <utility> 5 #include <utility>
6 6
7 #include "base/base_switches.h" 7 #include "base/base_switches.h"
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/bind_helpers.h" 9 #include "base/bind_helpers.h"
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 1160 matching lines...) Expand 10 before | Expand all | Expand 10 after
1171 // as page title. 1171 // as page title.
1172 const base::string16 result = watcher.WaitAndGetTitle(); 1172 const base::string16 result = watcher.WaitAndGetTitle();
1173 EXPECT_TRUE(base::LowerCaseEqualsASCII(result, "pass")); 1173 EXPECT_TRUE(base::LowerCaseEqualsASCII(result, "pass"));
1174 } 1174 }
1175 1175
1176 // Ensure that non-standard origins are marked correctly when the 1176 // Ensure that non-standard origins are marked correctly when the
1177 // MarkNonSecureAs field trial is enabled. 1177 // MarkNonSecureAs field trial is enabled.
1178 IN_PROC_BROWSER_TEST_F(SSLUITest, MarkFileAsNonSecure) { 1178 IN_PROC_BROWSER_TEST_F(SSLUITest, MarkFileAsNonSecure) {
1179 scoped_refptr<base::FieldTrial> trial = 1179 scoped_refptr<base::FieldTrial> trial =
1180 base::FieldTrialList::CreateFieldTrial( 1180 base::FieldTrialList::CreateFieldTrial(
1181 "MarkNonSecureAs", 1181 "MarkNonSecureAs", security_state::switches::kMarkHttpAsDangerous);
1182 security_state::switches::kMarkNonSecureAsNonSecure);
1183 1182
1184 content::WebContents* contents = 1183 content::WebContents* contents =
1185 browser()->tab_strip_model()->GetActiveWebContents(); 1184 browser()->tab_strip_model()->GetActiveWebContents();
1186 ASSERT_TRUE(contents); 1185 ASSERT_TRUE(contents);
1187 1186
1188 ChromeSecurityStateModelClient* model_client = 1187 ChromeSecurityStateModelClient* model_client =
1189 ChromeSecurityStateModelClient::FromWebContents(contents); 1188 ChromeSecurityStateModelClient::FromWebContents(contents);
1190 ASSERT_TRUE(model_client); 1189 ASSERT_TRUE(model_client);
1191 1190
1192 ui_test_utils::NavigateToURL(browser(), GURL("file:///")); 1191 ui_test_utils::NavigateToURL(browser(), GURL("file:///"));
1193 security_state::SecurityStateModel::SecurityInfo security_info; 1192 security_state::SecurityStateModel::SecurityInfo security_info;
1194 model_client->GetSecurityInfo(&security_info); 1193 model_client->GetSecurityInfo(&security_info);
1195 EXPECT_EQ(security_state::SecurityStateModel::NONE, 1194 EXPECT_EQ(security_state::SecurityStateModel::NONE,
1196 security_info.security_level); 1195 security_info.security_level);
1197 } 1196 }
1198 1197
1199 IN_PROC_BROWSER_TEST_F(SSLUITest, MarkAboutAsNonSecure) { 1198 IN_PROC_BROWSER_TEST_F(SSLUITest, MarkAboutAsNonSecure) {
1200 scoped_refptr<base::FieldTrial> trial = 1199 scoped_refptr<base::FieldTrial> trial =
1201 base::FieldTrialList::CreateFieldTrial( 1200 base::FieldTrialList::CreateFieldTrial(
1202 "MarkNonSecureAs", 1201 "MarkNonSecureAs", security_state::switches::kMarkHttpAsDangerous);
1203 security_state::switches::kMarkNonSecureAsNonSecure);
1204 1202
1205 content::WebContents* contents = 1203 content::WebContents* contents =
1206 browser()->tab_strip_model()->GetActiveWebContents(); 1204 browser()->tab_strip_model()->GetActiveWebContents();
1207 ASSERT_TRUE(contents); 1205 ASSERT_TRUE(contents);
1208 1206
1209 ChromeSecurityStateModelClient* model_client = 1207 ChromeSecurityStateModelClient* model_client =
1210 ChromeSecurityStateModelClient::FromWebContents(contents); 1208 ChromeSecurityStateModelClient::FromWebContents(contents);
1211 ASSERT_TRUE(model_client); 1209 ASSERT_TRUE(model_client);
1212 1210
1213 ui_test_utils::NavigateToURL(browser(), GURL("about:blank")); 1211 ui_test_utils::NavigateToURL(browser(), GURL("about:blank"));
1214 security_state::SecurityStateModel::SecurityInfo security_info; 1212 security_state::SecurityStateModel::SecurityInfo security_info;
1215 model_client->GetSecurityInfo(&security_info); 1213 model_client->GetSecurityInfo(&security_info);
1216 EXPECT_EQ(security_state::SecurityStateModel::NONE, 1214 EXPECT_EQ(security_state::SecurityStateModel::NONE,
1217 security_info.security_level); 1215 security_info.security_level);
1218 } 1216 }
1219 1217
1220 IN_PROC_BROWSER_TEST_F(SSLUITest, MarkDataAsNonSecure) { 1218 IN_PROC_BROWSER_TEST_F(SSLUITest, MarkDataAsNonSecure) {
1221 scoped_refptr<base::FieldTrial> trial = 1219 scoped_refptr<base::FieldTrial> trial =
1222 base::FieldTrialList::CreateFieldTrial( 1220 base::FieldTrialList::CreateFieldTrial(
1223 "MarkNonSecureAs", 1221 "MarkNonSecureAs", security_state::switches::kMarkHttpAsDangerous);
1224 security_state::switches::kMarkNonSecureAsNonSecure);
1225 1222
1226 content::WebContents* contents = 1223 content::WebContents* contents =
1227 browser()->tab_strip_model()->GetActiveWebContents(); 1224 browser()->tab_strip_model()->GetActiveWebContents();
1228 ASSERT_TRUE(contents); 1225 ASSERT_TRUE(contents);
1229 1226
1230 ChromeSecurityStateModelClient* model_client = 1227 ChromeSecurityStateModelClient* model_client =
1231 ChromeSecurityStateModelClient::FromWebContents(contents); 1228 ChromeSecurityStateModelClient::FromWebContents(contents);
1232 ASSERT_TRUE(model_client); 1229 ASSERT_TRUE(model_client);
1233 1230
1234 ui_test_utils::NavigateToURL(browser(), GURL("data:text/plain,hello")); 1231 ui_test_utils::NavigateToURL(browser(), GURL("data:text/plain,hello"));
1235 security_state::SecurityStateModel::SecurityInfo security_info; 1232 security_state::SecurityStateModel::SecurityInfo security_info;
1236 model_client->GetSecurityInfo(&security_info); 1233 model_client->GetSecurityInfo(&security_info);
1237 EXPECT_EQ(security_state::SecurityStateModel::NONE, 1234 EXPECT_EQ(security_state::SecurityStateModel::NONE,
1238 security_info.security_level); 1235 security_info.security_level);
1239 } 1236 }
1240 1237
1241 IN_PROC_BROWSER_TEST_F(SSLUITest, MarkBlobAsNonSecure) { 1238 IN_PROC_BROWSER_TEST_F(SSLUITest, MarkBlobAsNonSecure) {
1242 scoped_refptr<base::FieldTrial> trial = 1239 scoped_refptr<base::FieldTrial> trial =
1243 base::FieldTrialList::CreateFieldTrial( 1240 base::FieldTrialList::CreateFieldTrial(
1244 "MarkNonSecureAs", 1241 "MarkNonSecureAs", security_state::switches::kMarkHttpAsDangerous);
1245 security_state::switches::kMarkNonSecureAsNonSecure);
1246 1242
1247 content::WebContents* contents = 1243 content::WebContents* contents =
1248 browser()->tab_strip_model()->GetActiveWebContents(); 1244 browser()->tab_strip_model()->GetActiveWebContents();
1249 ASSERT_TRUE(contents); 1245 ASSERT_TRUE(contents);
1250 1246
1251 ChromeSecurityStateModelClient* model_client = 1247 ChromeSecurityStateModelClient* model_client =
1252 ChromeSecurityStateModelClient::FromWebContents(contents); 1248 ChromeSecurityStateModelClient::FromWebContents(contents);
1253 ASSERT_TRUE(model_client); 1249 ASSERT_TRUE(model_client);
1254 1250
1255 ui_test_utils::NavigateToURL( 1251 ui_test_utils::NavigateToURL(
(...skipping 2021 matching lines...) Expand 10 before | Expand all | Expand 10 after
3277 3273
3278 // Visit a page over https that contains a frame with a redirect. 3274 // Visit a page over https that contains a frame with a redirect.
3279 3275
3280 // XMLHttpRequest insecure content in synchronous mode. 3276 // XMLHttpRequest insecure content in synchronous mode.
3281 3277
3282 // XMLHttpRequest insecure content in asynchronous mode. 3278 // XMLHttpRequest insecure content in asynchronous mode.
3283 3279
3284 // XMLHttpRequest over bad ssl in synchronous mode. 3280 // XMLHttpRequest over bad ssl in synchronous mode.
3285 3281
3286 // XMLHttpRequest over OK ssl in synchronous mode. 3282 // XMLHttpRequest over OK ssl in synchronous mode.
OLDNEW
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | components/security_state/security_state_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698