Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 2342243003: Revert of Enable whitelisting for targets other than libchrome. (Closed)

Created:
4 years, 3 months ago by Yuta Kitamura
Modified:
4 years, 3 months ago
Reviewers:
brettw, miu, agrieve
CC:
chromium-reviews, extensions-reviews_chromium.org, alemate+watch_chromium.org, dtseng+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, sdefresne+watch_chromium.org, android-webview-reviews_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable whitelisting for targets other than libchrome. (patchset #2 id:90001 of https://codereview.chromium.org/2344063002/ ) Reason for revert: Still causing GN errors on Google Chrome bots (Win, Linux, and ChromeOS). https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/10926 C:\b\c\b\win_chrome\src\buildtools\win\gn.exe gen //out/Release --check -> returned 1 ERROR at //chrome/BUILD.gn:1358:19: Assignment had no effect. public_deps = [ ^ You set the variable "public_deps" here and it was unused before it went out of scope. See //BUILD.gn:211:7: which caused the file to be included. "//chrome", ^--------- GN gen failed: 1 step returned non-zero exit code: 1 Original issue's description: > Reland of Enable whitelisting for targets other than libchrome. > > Reverted in: > https://codereview.chromium.org/2348643002/ > > Reason for revert: > Fixed gn gen errror > > This will allow monochrome to easily define its own set of the same > targets with a different resource whitelist > > TBR=brettw@chromium.org,miu@chromium.org > BUG=641032 > > Committed: https://crrev.com/26cf65711c693aac13c897b67d0e138c3ee42ece > Cr-Commit-Position: refs/heads/master@{#419074} TBR=brettw@chromium.org,miu@chromium.org,agrieve@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=641032 Committed: https://crrev.com/455e3ec13d616b3121dc29451b90d2294db67f26 Cr-Commit-Position: refs/heads/master@{#419100}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -263 lines) Patch
M chrome/BUILD.gn View 7 chunks +216 lines, -40 lines 0 comments Download
D chrome/chrome_paks.gni View 1 chunk +0 lines, -220 lines 0 comments Download
M chrome/chrome_repack_locales.gni View 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Yuta Kitamura
Created Revert of Enable whitelisting for targets other than libchrome.
4 years, 3 months ago (2016-09-16 04:25:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2342243003/1
4 years, 3 months ago (2016-09-16 04:25:43 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 04:26:50 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/455e3ec13d616b3121dc29451b90d2294db67f26 Cr-Commit-Position: refs/heads/master@{#419100}
4 years, 3 months ago (2016-09-16 04:30:05 UTC) #7
agrieve
4 years, 3 months ago (2016-09-16 13:57:03 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2342023004/ by agrieve@chromium.org.

The reason for reverting is: Will update when fixed (for real! Sorry another
break).

Powered by Google App Engine
This is Rietveld 408576698