Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2342023004: Reland of Enable whitelisting for targets other than libchrome. (Closed)

Created:
4 years, 3 months ago by agrieve
Modified:
4 years, 3 months ago
Reviewers:
brettw, Yuta Kitamura, miu
CC:
chromium-reviews, extensions-reviews_chromium.org, alemate+watch_chromium.org, dtseng+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, sdefresne+watch_chromium.org, android-webview-reviews_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland #2 of Enable whitelisting for targets other than libchrome. Reverted in https://codereview.chromium.org/2342243003/ Reason for reland: Actually fixed gn gen failure. This will allow monochrome to easily define its own set of the same targets with a different resource whitelist TBR=brettw@chromium.org,miu@chromium.org,yutak@chromium.org BUG=641032 Committed: https://crrev.com/a6085a6a3f95d949f7b81361c901816c5e4a8dcf Cr-Commit-Position: refs/heads/master@{#419209}

Patch Set 1 #

Patch Set 2 : fix gn gen for real #

Unified diffs Side-by-side diffs Delta from patch set Stats (+257 lines, -217 lines) Patch
M chrome/BUILD.gn View 1 7 chunks +33 lines, -209 lines 0 comments Download
A chrome/chrome_paks.gni View 1 1 chunk +221 lines, -0 lines 0 comments Download
M chrome/chrome_repack_locales.gni View 1 2 chunks +3 lines, -8 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (6 generated)
agrieve
Created Reland of Enable whitelisting for targets other than libchrome.
4 years, 3 months ago (2016-09-16 13:57:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2342023004/90001
4 years, 3 months ago (2016-09-16 14:02:54 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/281161)
4 years, 3 months ago (2016-09-16 15:00:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2342023004/90001
4 years, 3 months ago (2016-09-16 16:56:04 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:90001)
4 years, 3 months ago (2016-09-16 17:48:36 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 17:51:20 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a6085a6a3f95d949f7b81361c901816c5e4a8dcf
Cr-Commit-Position: refs/heads/master@{#419209}

Powered by Google App Engine
This is Rietveld 408576698