Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2341303002: MIPS: Port for (fused) multiply add/subtract. (Closed)

Created:
4 years, 3 months ago by Ilija.Pavlovic1
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Port for (fused) multiply add/subtract. Port for VisitFloat32Add, VisitFloat64Add, VisitFloat32Sub and VisitFloat64Sub in InstructionSelector. TEST=unittests/InstructionSelectorTest.Float32AddWithFloat32Mul, unittests/InstructionSelectorTest.Float64AddWithFloat64Mul, unittests/InstructionSelectorTest.Float32SubWithFloat32Mul, unittests/InstructionSelectorTest.Float64SubWithFloat64Mul BUG= Committed: https://crrev.com/502b9aa71b1b28578579083f11f8bc67e4cd3430 Cr-Commit-Position: refs/heads/master@{#39616}

Patch Set 1 #

Patch Set 2 : Fixed errors. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+686 lines, -0 lines) Patch
M src/compiler/mips/code-generator-mips.cc View 1 chunk +32 lines, -0 lines 0 comments Download
M src/compiler/mips/instruction-codes-mips.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 1 chunk +106 lines, -0 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +32 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-codes-mips64.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 1 chunk +106 lines, -0 lines 0 comments Download
M test/unittests/compiler/mips/instruction-selector-mips-unittest.cc View 1 1 chunk +197 lines, -0 lines 0 comments Download
M test/unittests/compiler/mips64/instruction-selector-mips64-unittest.cc View 1 1 chunk +197 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Ilija.Pavlovic1
PTAL.
4 years, 3 months ago (2016-09-16 13:16:22 UTC) #2
balazs.kilvady
lgtm
4 years, 3 months ago (2016-09-19 08:36:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2341303002/20001
4 years, 3 months ago (2016-09-22 08:16:30 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-22 08:42:46 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 08:43:16 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/502b9aa71b1b28578579083f11f8bc67e4cd3430
Cr-Commit-Position: refs/heads/master@{#39616}

Powered by Google App Engine
This is Rietveld 408576698