Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp

Issue 2341053002: Mark the createVisiblePosition overloads as deprecated (Closed)
Patch Set: minor revision Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp
diff --git a/third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp b/third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp
index 7e894f039ef235beb0da4e1ddb2e4fc3b9045bdf..be14efc844e677fc7a76b8770f17d2ff0b2c772e 100644
--- a/third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp
+++ b/third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp
@@ -91,9 +91,9 @@ bool IndentOutdentCommand::tryIndentingAsListItem(const Position& start, const P
// selection does not encompass all its children, we need to explicitally handle the same. The original
// list item too would require proper deletion in that case.
if (end.anchorNode() == selectedListItem || end.anchorNode()->isDescendantOf(selectedListItem->lastChild())) {
- moveParagraphWithClones(createVisiblePosition(start), createVisiblePosition(end), newList, selectedListItem, editingState);
+ moveParagraphWithClones(createVisiblePositionDeprecated(start), createVisiblePositionDeprecated(end), newList, selectedListItem, editingState);
} else {
- moveParagraphWithClones(createVisiblePosition(start), VisiblePosition::afterNode(selectedListItem->lastChild()), newList, selectedListItem, editingState);
+ moveParagraphWithClones(createVisiblePositionDeprecated(start), VisiblePosition::afterNode(selectedListItem->lastChild()), newList, selectedListItem, editingState);
if (editingState->isAborted())
return false;
removeNode(selectedListItem, editingState);
@@ -131,7 +131,7 @@ void IndentOutdentCommand::indentIntoBlockquote(const Position& start, const Pos
Node* outerBlock = (start.computeContainerNode() == elementToSplitTo) ? start.computeContainerNode() : splitTreeToNode(start.computeContainerNode(), elementToSplitTo);
- VisiblePosition startOfContents = createVisiblePosition(start);
+ VisiblePosition startOfContents = createVisiblePositionDeprecated(start);
if (!targetBlockquote) {
// Create a new blockquote and insert it as a child of the root editable element. We accomplish
// this by splitting all parents of the current paragraph up to that point.
@@ -150,7 +150,7 @@ void IndentOutdentCommand::indentIntoBlockquote(const Position& start, const Pos
startOfContents = VisiblePosition::inParentAfterNode(*targetBlockquote);
}
- VisiblePosition endOfContents = createVisiblePosition(end);
+ VisiblePosition endOfContents = createVisiblePositionDeprecated(end);
if (startOfContents.isNull() || endOfContents.isNull())
return;
moveParagraphWithClones(startOfContents, endOfContents, targetBlockquote, outerBlock, editingState);
@@ -201,8 +201,8 @@ void IndentOutdentCommand::outdentParagraph(EditingState* editingState)
}
document().updateStyleAndLayoutIgnorePendingStylesheets();
- visibleStartOfParagraph = createVisiblePosition(visibleStartOfParagraph.deepEquivalent());
- visibleEndOfParagraph = createVisiblePosition(visibleEndOfParagraph.deepEquivalent());
+ visibleStartOfParagraph = createVisiblePositionDeprecated(visibleStartOfParagraph.deepEquivalent());
+ visibleEndOfParagraph = createVisiblePositionDeprecated(visibleEndOfParagraph.deepEquivalent());
if (visibleStartOfParagraph.isNotNull() && !isStartOfParagraph(visibleStartOfParagraph)) {
insertNodeAt(HTMLBRElement::create(document()), visibleStartOfParagraph.deepEquivalent(), editingState);
if (editingState->isAborted())
@@ -265,7 +265,7 @@ void IndentOutdentCommand::outdentRegion(const VisiblePosition& startOfSelection
break;
if (endOfNextParagraph.isNotNull() && !endOfNextParagraph.deepEquivalent().isConnected()) {
- endOfCurrentParagraph = createVisiblePosition(endingSelection().end());
+ endOfCurrentParagraph = createVisiblePositionDeprecated(endingSelection().end());
endOfNextParagraph = endOfParagraph(nextPositionOf(endOfCurrentParagraph));
}
endOfCurrentParagraph = endOfNextParagraph;

Powered by Google App Engine
This is Rietveld 408576698