third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp - Issue 2341053002: Mark the createVisiblePosition overloads as deprecated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

Issue 2341053002: Mark the createVisiblePosition overloads as deprecated (Closed)

Patch Set: minor revision Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/RelocatablePositionTest.cpp ('K') | « third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp » ('j') | third_party/WebKit/Source/core/layout/HitTestResult.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp b/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

index 3f039cdb7bed09151fb314b18b47b0a0e732849a..03cb72a3c5d3f35d9e445ae3c8c4b1176bd561ef 100644

--- a/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

@@ -283,8 +283,8 @@ bool InsertListCommand::doApplyForSingleParagraph(bool forceCreateList, const HT

// If the entire list is selected, then convert the whole list.

if (switchListType && isNodeVisiblyContainedWithin(*listElement, currentSelection)) {

- bool rangeStartIsInList = visiblePositionBeforeNode(*listElement).deepEquivalent() == createVisiblePosition(currentSelection.startPosition()).deepEquivalent();

- bool rangeEndIsInList = visiblePositionAfterNode(*listElement).deepEquivalent() == createVisiblePosition(currentSelection.endPosition()).deepEquivalent();

+ bool rangeStartIsInList = visiblePositionBeforeNode(*listElement).deepEquivalent() == createVisiblePositionDeprecated(currentSelection.startPosition()).deepEquivalent();

+ bool rangeEndIsInList = visiblePositionAfterNode(*listElement).deepEquivalent() == createVisiblePositionDeprecated(currentSelection.endPosition()).deepEquivalent();

HTMLElement* newList = createHTMLElement(document(), listTag);

insertNodeBefore(newList, listElement, editingState);

@@ -489,7 +489,7 @@ void InsertListCommand::listifyParagraph(const VisiblePosition& originalStart, c

if (insertionPos == startPos)

moveParagraphOverPositionIntoEmptyListItem(originalStart, listItemElement, editingState);

else

- moveParagraphOverPositionIntoEmptyListItem(createVisiblePosition(startPos), listItemElement, editingState);

+ moveParagraphOverPositionIntoEmptyListItem(createVisiblePositionDeprecated(startPos), listItemElement, editingState);

if (editingState->isAborted())

return;