Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 2339173004: Revert of [inspector] fixed all shorten-64-to-32 warnings (Closed)

Created:
4 years, 3 months ago by Michael Hablich
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [inspector] fixed all shorten-64-to-32 warnings (patchset #4 id:80001 of https://codereview.chromium.org/2332163002/ ) Reason for revert: Blocking V8 roll: https://codereview.chromium.org/2347463002/ See https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/293368 for compile error. Original issue's description: > [inspector] fixed all shorten-64-to-32 warnings > > BUG=chromium:635948 > R=dgozman@chromium.org,alph@chromium.org > > Committed: https://crrev.com/3d10918d2e1c57d72531c55a956262f5a72fceaa > Cr-Commit-Position: refs/heads/master@{#39426} TBR=jochen@chromium.org,alph@chromium.org,dgozman@chromium.org,kozyatinskiy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:635948 Committed: https://crrev.com/4b8f6543f497094ee33d8f9d7ae0b5a46f22c23f Cr-Commit-Position: refs/heads/master@{#39432}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -130 lines) Patch
M include/v8-inspector.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/inspector/InjectedScript.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/inspector/SearchUtil.cpp View 5 chunks +14 lines, -14 lines 0 comments Download
M src/inspector/String16.h View 2 chunks +4 lines, -5 lines 0 comments Download
M src/inspector/String16.cpp View 6 chunks +8 lines, -20 lines 0 comments Download
M src/inspector/StringUtil.h View 1 chunk +2 lines, -5 lines 0 comments Download
M src/inspector/StringUtil.cpp View 3 chunks +8 lines, -20 lines 0 comments Download
M src/inspector/V8Console.cpp View 5 chunks +10 lines, -10 lines 0 comments Download
M src/inspector/V8Debugger.cpp View 4 chunks +7 lines, -11 lines 0 comments Download
M src/inspector/V8DebuggerAgentImpl.cpp View 2 chunks +4 lines, -6 lines 0 comments Download
M src/inspector/V8DebuggerScript.cpp View 2 chunks +15 lines, -19 lines 0 comments Download
M src/inspector/V8FunctionCall.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/inspector/V8HeapProfilerAgentImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/inspector/V8InternalValueType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/inspector/V8RuntimeAgentImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/inspector/V8StackTraceImpl.cpp View 3 chunks +3 lines, -7 lines 0 comments Download
M src/inspector/V8ValueCopier.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/v8.gyp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Michael Hablich
Created Revert of [inspector] fixed all shorten-64-to-32 warnings
4 years, 3 months ago (2016-09-15 00:35:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2339173004/1
4 years, 3 months ago (2016-09-15 00:35:11 UTC) #3
commit-bot: I haz the power
Failed to apply patch for src/v8.gyp: While running git apply --index -3 -p1; error: patch ...
4 years, 3 months ago (2016-09-15 00:35:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2339173004/1
4 years, 3 months ago (2016-09-15 00:41:34 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 00:41:52 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 00:42:16 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4b8f6543f497094ee33d8f9d7ae0b5a46f22c23f
Cr-Commit-Position: refs/heads/master@{#39432}

Powered by Google App Engine
This is Rietveld 408576698