Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: src/inspector/V8ValueCopier.cpp

Issue 2339173004: Revert of [inspector] fixed all shorten-64-to-32 warnings (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/inspector/V8StackTraceImpl.cpp ('k') | src/v8.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/inspector/V8ValueCopier.cpp
diff --git a/src/inspector/V8ValueCopier.cpp b/src/inspector/V8ValueCopier.cpp
index 7d64fb53fc70c4866c326e3b9c45da37c93f8c85..a61fafe9128e917969ae2bf1ac26893db418e289 100644
--- a/src/inspector/V8ValueCopier.cpp
+++ b/src/inspector/V8ValueCopier.cpp
@@ -30,7 +30,7 @@
v8::Local<v8::Array> result = v8::Array::New(m_isolate, array->Length());
if (!result->SetPrototype(m_to, v8::Null(m_isolate)).FromMaybe(false))
return v8::MaybeLocal<v8::Value>();
- for (uint32_t i = 0; i < array->Length(); ++i) {
+ for (size_t i = 0; i < array->Length(); ++i) {
v8::Local<v8::Value> item;
if (!array->Get(m_from, i).ToLocal(&item))
return v8::MaybeLocal<v8::Value>();
@@ -49,7 +49,7 @@
v8::Local<v8::Array> properties;
if (!object->GetOwnPropertyNames(m_from).ToLocal(&properties))
return v8::MaybeLocal<v8::Value>();
- for (uint32_t i = 0; i < properties->Length(); ++i) {
+ for (size_t i = 0; i < properties->Length(); ++i) {
v8::Local<v8::Value> name;
if (!properties->Get(m_from, i).ToLocal(&name) || !name->IsString())
return v8::MaybeLocal<v8::Value>();
« no previous file with comments | « src/inspector/V8StackTraceImpl.cpp ('k') | src/v8.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698