Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Unified Diff: src/inspector/V8Console.cpp

Issue 2339173004: Revert of [inspector] fixed all shorten-64-to-32 warnings (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/inspector/StringUtil.cpp ('k') | src/inspector/V8Debugger.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/inspector/V8Console.cpp
diff --git a/src/inspector/V8Console.cpp b/src/inspector/V8Console.cpp
index a830b9eac65913932ace26c7f160af707a7dd72b..33ba0a5102b1fe501da417e74d73a3e4391347f1 100644
--- a/src/inspector/V8Console.cpp
+++ b/src/inspector/V8Console.cpp
@@ -160,16 +160,16 @@
: v8::MaybeLocal<v8::Map>();
}
- int32_t getIntFromMap(v8::Local<v8::Map> map, const String16& key,
- int32_t defaultValue) {
+ int64_t getIntFromMap(v8::Local<v8::Map> map, const String16& key,
+ int64_t defaultValue) {
v8::Local<v8::String> v8Key = toV8String(m_isolate, key);
if (!map->Has(m_context, v8Key).FromMaybe(false)) return defaultValue;
v8::Local<v8::Value> intValue;
if (!map->Get(m_context, v8Key).ToLocal(&intValue)) return defaultValue;
- return static_cast<int32_t>(intValue.As<v8::Integer>()->Value());
- }
-
- void setIntOnMap(v8::Local<v8::Map> map, const String16& key, int32_t value) {
+ return intValue.As<v8::Integer>()->Value();
+ }
+
+ void setIntOnMap(v8::Local<v8::Map> map, const String16& key, int64_t value) {
v8::Local<v8::String> v8Key = toV8String(m_isolate, key);
if (!map->Set(m_context, v8Key, v8::Integer::New(m_isolate, value))
.ToLocal(&map))
@@ -353,7 +353,7 @@
v8::Local<v8::Map> countMap;
if (!helper.privateMap("V8Console#countMap").ToLocal(&countMap)) return;
- int32_t count = helper.getIntFromMap(countMap, identifier, 0) + 1;
+ int64_t count = helper.getIntFromMap(countMap, identifier, 0) + 1;
helper.setIntOnMap(countMap, identifier, count);
helper.reportCallWithArgument(ConsoleAPIType::kCount,
title + ": " + String16::fromInteger(count));
@@ -511,7 +511,7 @@
v8::Local<v8::Context> context = isolate->GetCurrentContext();
if (!obj->GetOwnPropertyNames(context).ToLocal(&names)) return;
v8::Local<v8::Array> values = v8::Array::New(isolate, names->Length());
- for (uint32_t i = 0; i < names->Length(); ++i) {
+ for (size_t i = 0; i < names->Length(); ++i) {
v8::Local<v8::Value> key;
if (!names->Get(context, i).ToLocal(&key)) continue;
v8::Local<v8::Value> value;
@@ -876,7 +876,7 @@
if (!m_commandLineAPI->GetOwnPropertyNames(context).ToLocal(&names)) return;
v8::Local<v8::External> externalThis =
v8::External::New(context->GetIsolate(), this);
- for (uint32_t i = 0; i < names->Length(); ++i) {
+ for (size_t i = 0; i < names->Length(); ++i) {
v8::Local<v8::Value> name;
if (!names->Get(context, i).ToLocal(&name) || !name->IsName()) continue;
if (m_global->Has(context, name).FromMaybe(true)) continue;
@@ -899,7 +899,7 @@
V8Console::CommandLineAPIScope::~CommandLineAPIScope() {
m_cleanup = true;
v8::Local<v8::Array> names = m_installedMethods->AsArray();
- for (uint32_t i = 0; i < names->Length(); ++i) {
+ for (size_t i = 0; i < names->Length(); ++i) {
v8::Local<v8::Value> name;
if (!names->Get(m_context, i).ToLocal(&name) || !name->IsName()) continue;
if (name->IsString()) {
« no previous file with comments | « src/inspector/StringUtil.cpp ('k') | src/inspector/V8Debugger.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698