Revert of [inspector] fixed all shorten-64-to-32 warnings

src/inspector/V8Console.cpp

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/inspector/V8Console.h"
 
 #include "src/base/macros.h"
 #include "src/inspector/InjectedScript.h"
 #include "src/inspector/InspectedContext.h"
 #include "src/inspector/StringUtil.h"
@@ skipping 142 matching lines @@
     if (mapValue->IsUndefined()) {
       v8::Local<v8::Map> map = v8::Map::New(m_isolate);
       if (!console->SetPrivate(m_context, privateKey, map).FromMaybe(false))
         return v8::MaybeLocal<v8::Map>();
       return map;
     }
     return mapValue->IsMap() ? mapValue.As<v8::Map>()
                              : v8::MaybeLocal<v8::Map>();
   }
 
-  int32_t getIntFromMap(v8::Local<v8::Map> map, const String16& key,
-                        int32_t defaultValue) {
+  int64_t getIntFromMap(v8::Local<v8::Map> map, const String16& key,
+                        int64_t defaultValue) {
     v8::Local<v8::String> v8Key = toV8String(m_isolate, key);
     if (!map->Has(m_context, v8Key).FromMaybe(false)) return defaultValue;
     v8::Local<v8::Value> intValue;
     if (!map->Get(m_context, v8Key).ToLocal(&intValue)) return defaultValue;
-    return static_cast<int32_t>(intValue.As<v8::Integer>()->Value());
+    return intValue.As<v8::Integer>()->Value();
   }
 
-  void setIntOnMap(v8::Local<v8::Map> map, const String16& key, int32_t value) {
+  void setIntOnMap(v8::Local<v8::Map> map, const String16& key, int64_t value) {
     v8::Local<v8::String> v8Key = toV8String(m_isolate, key);
     if (!map->Set(m_context, v8Key, v8::Integer::New(m_isolate, value))
              .ToLocal(&map))
       return;
   }
 
   double getDoubleFromMap(v8::Local<v8::Map> map, const String16& key,
                           double defaultValue) {
     v8::Local<v8::String> v8Key = toV8String(m_isolate, key);
     if (!map->Has(m_context, v8Key).FromMaybe(false)) return defaultValue;
@@ skipping 163 matching lines @@
         V8StackTraceImpl::capture(nullptr, 0, 1);
     if (stackTrace)
       identifier = toString16(stackTrace->topSourceURL()) + ":" +
                    String16::fromInteger(stackTrace->topLineNumber());
   } else {
     identifier = title + "@";
   }
 
   v8::Local<v8::Map> countMap;
   if (!helper.privateMap("V8Console#countMap").ToLocal(&countMap)) return;
-  int32_t count = helper.getIntFromMap(countMap, identifier, 0) + 1;
+  int64_t count = helper.getIntFromMap(countMap, identifier, 0) + 1;
   helper.setIntOnMap(countMap, identifier, count);
   helper.reportCallWithArgument(ConsoleAPIType::kCount,
                                 title + ": " + String16::fromInteger(count));
 }
 
 void V8Console::assertCallback(
     const v8::FunctionCallbackInfo<v8::Value>& info) {
   ConsoleHelper helper(info);
   if (helper.firstArgToBoolean(false)) return;
 
@@ skipping 137 matching lines @@
   v8::Isolate* isolate = info.GetIsolate();
   info.GetReturnValue().Set(v8::Array::New(isolate));
 
   ConsoleHelper helper(info);
   v8::Local<v8::Object> obj;
   if (!helper.firstArgAsObject().ToLocal(&obj)) return;
   v8::Local<v8::Array> names;
   v8::Local<v8::Context> context = isolate->GetCurrentContext();
   if (!obj->GetOwnPropertyNames(context).ToLocal(&names)) return;
   v8::Local<v8::Array> values = v8::Array::New(isolate, names->Length());
-  for (uint32_t i = 0; i < names->Length(); ++i) {
+  for (size_t i = 0; i < names->Length(); ++i) {
     v8::Local<v8::Value> key;
     if (!names->Get(context, i).ToLocal(&key)) continue;
     v8::Local<v8::Value> value;
     if (!obj->Get(context, key).ToLocal(&value)) continue;
     createDataProperty(context, values, i, value);
   }
   info.GetReturnValue().Set(values);
 }
 
 static void setFunctionBreakpoint(ConsoleHelper& helper,
@@ skipping 344 matching lines @@
     v8::Local<v8::Object> global)
     : m_context(context),
       m_commandLineAPI(commandLineAPI),
       m_global(global),
       m_installedMethods(v8::Set::New(context->GetIsolate())),
       m_cleanup(false) {
   v8::Local<v8::Array> names;
   if (!m_commandLineAPI->GetOwnPropertyNames(context).ToLocal(&names)) return;
   v8::Local<v8::External> externalThis =
       v8::External::New(context->GetIsolate(), this);
-  for (uint32_t i = 0; i < names->Length(); ++i) {
+  for (size_t i = 0; i < names->Length(); ++i) {
     v8::Local<v8::Value> name;
     if (!names->Get(context, i).ToLocal(&name) || !name->IsName()) continue;
     if (m_global->Has(context, name).FromMaybe(true)) continue;
     if (!m_installedMethods->Add(context, name).ToLocal(&m_installedMethods))
       continue;
     if (!m_global
              ->SetAccessor(context, v8::Local<v8::Name>::Cast(name),
                            CommandLineAPIScope::accessorGetterCallback,
                            CommandLineAPIScope::accessorSetterCallback,
                            externalThis, v8::DEFAULT, v8::DontEnum)
              .FromMaybe(false)) {
       bool removed = m_installedMethods->Delete(context, name).FromMaybe(false);
       DCHECK(removed);
       USE(removed);
       continue;
     }
   }
 }
 
 V8Console::CommandLineAPIScope::~CommandLineAPIScope() {
   m_cleanup = true;
   v8::Local<v8::Array> names = m_installedMethods->AsArray();
-  for (uint32_t i = 0; i < names->Length(); ++i) {
+  for (size_t i = 0; i < names->Length(); ++i) {
     v8::Local<v8::Value> name;
     if (!names->Get(m_context, i).ToLocal(&name) || !name->IsName()) continue;
     if (name->IsString()) {
       v8::Local<v8::Value> descriptor;
       bool success = m_global
                          ->GetOwnPropertyDescriptor(
                              m_context, v8::Local<v8::String>::Cast(name))
                          .ToLocal(&descriptor);
       DCHECK(success);
       USE(success);
     }
   }
 }
 
 }  // namespace v8_inspector