Refactor prior to adding task-page

Refactor prior to adding task-page

There should be no real visual changes here. This is minor bug fixes and
refactoring to aid in the addition of task-page.

This fixes the name of "limit"->"_limit" in the two filters.  The latter
was declared but the former was used.

_taskLink and _botLink are consolidated into the common behavior to avoid
duplication (and fixing the links in multiple places)

Many styles that will be used by task-page are pulled out of bot-page and into
single-page-style.

_timeDiff* are pulled into common behavior (they will be used in task-page)

_humanDuration is created in common behavior (to consolidate and allow for use
in the templates of task-page)

buttons now look more clickable (pointer cursor)

task-list sorts times better when they don't have one

task-list uses human.localeTime like the rest of the app

The pages titles have been changed to be more useful when more tabs are open.
Instead of "Swarming Bot List", it is now "Bot List - Swarming", which means
if you have 20 tabs open, you see "Bot Li" instead of "Swarmin", which makes
it easier to find the right tab.

BUG=631047
Committed: https://github.com/luci/luci-py/commit/84f27f987cc82440fd47edb33e379f6505f6938a

[kjlubick, 2016-09-14 19:08:38]

Description was changed from

==========
Refactor prior to adding task-page

There should be no real visual changes here.

BUG=631047
==========

to

==========
Refactor prior to adding task-page

There should be no real visual changes here. This is minor bug fixes and
refactoring to aid in the addition of task-page.

This fixes the name of "limit"->"_limit" in the two filters.  The latter
was declared but the former was used.

_taskLink and _botLink are consolidated into the common behavior to avoid
duplication (and fixing the links in multiple places)

Many styles that will be used by task-page are pulled out of bot-page and into
single-page-style.

_timeDiff* are pulled into common behavior (they will be used in task-page)

_humanDuration is created in common behavior (to consolidate and allow for use
in the templates of task-page)

buttons now look more clickable (pointer cursor)

task-list sorts times better when they don't have one

task-list uses human.localeTime like the rest of the app


BUG=631047
==========

[kjlubick, 2016-09-14 19:11:14]

kjlubick@google.com changed reviewers:
+ jcgregorio@google.com, stephana@google.com

[kjlubick, 2016-09-14 19:25:44]

Description was changed from

==========
Refactor prior to adding task-page

There should be no real visual changes here. This is minor bug fixes and
refactoring to aid in the addition of task-page.

This fixes the name of "limit"->"_limit" in the two filters.  The latter
was declared but the former was used.

_taskLink and _botLink are consolidated into the common behavior to avoid
duplication (and fixing the links in multiple places)

Many styles that will be used by task-page are pulled out of bot-page and into
single-page-style.

_timeDiff* are pulled into common behavior (they will be used in task-page)

_humanDuration is created in common behavior (to consolidate and allow for use
in the templates of task-page)

buttons now look more clickable (pointer cursor)

task-list sorts times better when they don't have one

task-list uses human.localeTime like the rest of the app


BUG=631047
==========

to

==========
Refactor prior to adding task-page

There should be no real visual changes here. This is minor bug fixes and
refactoring to aid in the addition of task-page.

This fixes the name of "limit"->"_limit" in the two filters.  The latter
was declared but the former was used.

_taskLink and _botLink are consolidated into the common behavior to avoid
duplication (and fixing the links in multiple places)

Many styles that will be used by task-page are pulled out of bot-page and into
single-page-style.

_timeDiff* are pulled into common behavior (they will be used in task-page)

_humanDuration is created in common behavior (to consolidate and allow for use
in the templates of task-page)

buttons now look more clickable (pointer cursor)

task-list sorts times better when they don't have one

task-list uses human.localeTime like the rest of the app

The pages titles have been changed to be more useful when more tabs are open.
Instead of "Swarming Bot List", it is now "Bot List - Swarming", which means
if you have 20 tabs open, you see "Bot Li" instead of "Swarmin", which makes
it easier to find the right tab.

BUG=631047
==========

[stephana, 2016-09-15 16:33:52]

LGTM modulo some nits

https://codereview.chromium.org/2338383002/diff/60001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/botlist/bot-filters.html (right):

https://codereview.chromium.org/2338383002/diff/60001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/botlist/bot-filters.html:276: var lim =
parseInt(this._limit)
Nit: missing semicolon

https://codereview.chromium.org/2338383002/diff/60001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/common/common-behavior.html (right):

https://codereview.chromium.org/2338383002/diff/60001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/common/common-behavior.html:90: //
timeDiffApprox returns the approximate difference between now and
nit: should be _timeDiffApprox

https://codereview.chromium.org/2338383002/diff/60001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/tasklist/task-filters.html (right):

https://codereview.chromium.org/2338383002/diff/60001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/tasklist/task-filters.html:228: var lim =
parseInt(this._limit)
nit: Missing semicolon

[kjlubick, 2016-09-15 16:59:32]

https://codereview.chromium.org/2338383002/diff/60001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/botlist/bot-filters.html (right):

https://codereview.chromium.org/2338383002/diff/60001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/botlist/bot-filters.html:276: var lim =
parseInt(this._limit)
On 2016/09/15 at 16:33:52, stephana wrote:
> Nit: missing semicolon

Done.

https://codereview.chromium.org/2338383002/diff/60001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/common/common-behavior.html (right):

https://codereview.chromium.org/2338383002/diff/60001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/common/common-behavior.html:90: //
timeDiffApprox returns the approximate difference between now and
On 2016/09/15 at 16:33:52, stephana wrote:
> nit: should be _timeDiffApprox

Done.

https://codereview.chromium.org/2338383002/diff/60001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/tasklist/task-filters.html (right):

https://codereview.chromium.org/2338383002/diff/60001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/tasklist/task-filters.html:228: var lim =
parseInt(this._limit)
On 2016/09/15 at 16:33:52, stephana wrote:
> nit: Missing semicolon

Done.

[kjlubick, 2016-09-19 18:16:22]

The CQ bit was checked by kjlubick@google.com

[kjlubick, 2016-09-19 18:16:23]

The patchset sent to the CQ was uploaded after l-g-t-m from stephana@google.com
Link to the patchset: https://codereview.chromium.org/2338383002/#ps80001
(title: "Address nits")

[commit-bot: I haz the power, 2016-09-19 18:16:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 18:16:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 18:16:28]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-infra-committers".
Note that this has nothing to do with OWNERS files.

[KevinL, 2016-09-19 18:22:37]

kjlubick@chromium.org changed reviewers:
+ kjlubick@chromium.org

[KevinL, 2016-09-19 18:22:38]

lgtm

[KevinL, 2016-09-19 18:22:40]

The CQ bit was checked by kjlubick@chromium.org

[commit-bot: I haz the power, 2016-09-19 18:22:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 18:26:24]

Description was changed from

==========
Refactor prior to adding task-page

There should be no real visual changes here. This is minor bug fixes and
refactoring to aid in the addition of task-page.

This fixes the name of "limit"->"_limit" in the two filters.  The latter
was declared but the former was used.

_taskLink and _botLink are consolidated into the common behavior to avoid
duplication (and fixing the links in multiple places)

Many styles that will be used by task-page are pulled out of bot-page and into
single-page-style.

_timeDiff* are pulled into common behavior (they will be used in task-page)

_humanDuration is created in common behavior (to consolidate and allow for use
in the templates of task-page)

buttons now look more clickable (pointer cursor)

task-list sorts times better when they don't have one

task-list uses human.localeTime like the rest of the app

The pages titles have been changed to be more useful when more tabs are open.
Instead of "Swarming Bot List", it is now "Bot List - Swarming", which means
if you have 20 tabs open, you see "Bot Li" instead of "Swarmin", which makes
it easier to find the right tab.

BUG=631047
==========

to

==========
Refactor prior to adding task-page

There should be no real visual changes here. This is minor bug fixes and
refactoring to aid in the addition of task-page.

This fixes the name of "limit"->"_limit" in the two filters.  The latter
was declared but the former was used.

_taskLink and _botLink are consolidated into the common behavior to avoid
duplication (and fixing the links in multiple places)

Many styles that will be used by task-page are pulled out of bot-page and into
single-page-style.

_timeDiff* are pulled into common behavior (they will be used in task-page)

_humanDuration is created in common behavior (to consolidate and allow for use
in the templates of task-page)

buttons now look more clickable (pointer cursor)

task-list sorts times better when they don't have one

task-list uses human.localeTime like the rest of the app

The pages titles have been changed to be more useful when more tabs are open.
Instead of "Swarming Bot List", it is now "Bot List - Swarming", which means
if you have 20 tabs open, you see "Bot Li" instead of "Swarmin", which makes
it easier to find the right tab.

BUG=631047

Committed:
https://github.com/luci/luci-py/commit/84f27f987cc82440fd47edb33e379f6505f6938a
==========

[commit-bot: I haz the power, 2016-09-19 18:26:25]

Committed patchset #5 (id:80001) as
https://github.com/luci/luci-py/commit/84f27f987cc82440fd47edb33e379f6505f6938a