Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Unified Diff: appengine/swarming/elements/res/imp/tasklist/task-list.html

Issue 2338383002: Refactor prior to adding task-page (Closed) Base URL: git@github.com:luci/luci-py@master
Patch Set: Address nits Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/swarming/elements/res/imp/tasklist/task-list.html
diff --git a/appengine/swarming/elements/res/imp/tasklist/task-list.html b/appengine/swarming/elements/res/imp/tasklist/task-list.html
index 14882c16ebff1ec308ac77b2586b395c4ebd4f11..71d027fc0c3fc003a7c861c294ba328a34f0a425 100644
--- a/appengine/swarming/elements/res/imp/tasklist/task-list.html
+++ b/appengine/swarming/elements/res/imp/tasklist/task-list.html
@@ -268,8 +268,8 @@
// "2016-08-16T13:12:40.606300" which sorts correctly. Locale time
// (used in the columns), does not.
return function(dir, a, b) {
- var aCol = this._attribute(a, attr)[0];
- var bCol = this._attribute(b, attr)[0];
+ var aCol = this._attribute(a, attr, "0")[0];
+ var bCol = this._attribute(b, attr, "0")[0];
return dir * (aCol - bCol);
}
@@ -370,14 +370,6 @@
return task.tagMap[col];
},
- _taskLink: function(taskId) {
- if (!taskId) {
- return undefined;
- }
- // TODO(kjlubick) Make this point to /newui/ when appropriate.
- return "/user/task/"+taskId;
- },
-
_taskClass: function(task) {
var state = this._column("state", task);
if (state === "CANCELED" ||state === "TIMED_OUT" || state === "EXPIRED") {

Powered by Google App Engine
This is Rietveld 408576698