Let auth credentials autorefresh and fix new tab

Let auth credentials autorefresh and fix new tab

The auth signin doesn't happen if the page
is opened in a new tab.  This is likely because the user 
is already logged in, so we just reuse the credentials.

Additionally, this prevents the credentials from expiring.

BUG=631047
Committed: https://github.com/luci/luci-py/commit/cd808e1138f16101899a9f6409eda3a647a41381

[kjlubick, 2016-09-15 14:46:49]

Description was changed from

==========
Let auth credentials autorefresh

BUG=631047
==========

to

==========
Let auth credentials autorefresh and fix new tab

For whatever reason, the auth signin doesn't happen if the page
is opened in a new tab.  This adds a work around.

Additionally, this prevents the credentials from expiring.

BUG=631047
==========

[kjlubick, 2016-09-15 15:00:02]

Description was changed from

==========
Let auth credentials autorefresh and fix new tab

For whatever reason, the auth signin doesn't happen if the page
is opened in a new tab.  This adds a work around.

Additionally, this prevents the credentials from expiring.

BUG=631047
==========

to

==========
Let auth credentials autorefresh and fix new tab

The auth signin doesn't happen if the page
is opened in a new tab.  This is likely because the user 
is already logged in, so we just reuse the credentials.

Additionally, this prevents the credentials from expiring.

BUG=631047
==========

[kjlubick, 2016-09-15 15:00:03]

kjlubick@google.com changed reviewers:
+ jcgregorio@google.com, stephana@google.com

[jcgregorio, 2016-09-20 12:58:19]

https://codereview.chromium.org/2344883002/diff/60001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/common/auth-signin.html (right):

https://codereview.chromium.org/2344883002/diff/60001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/common/auth-signin.html:96: _signingIn: {
_signingIn seems to be needed because you are using setInterval.

If you switch to setTimeout and recall setTimeout within then you won't have to
worry about calling _onSignin() more than once, and can drop _signingIn.

https://codereview.chromium.org/2344883002/diff/60001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/common/auth-signin.html:134: 
No blank line here.

https://codereview.chromium.org/2344883002/diff/60001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/common/auth-signin.html:151:
console.log("reloading credentials");
Is the console.log needed?

[kjlubick, 2016-09-20 13:24:02]

https://codereview.chromium.org/2344883002/diff/60001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/common/auth-signin.html (right):

https://codereview.chromium.org/2344883002/diff/60001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/common/auth-signin.html:96: _signingIn: {
On 2016/09/20 at 12:58:18, jcgregorio wrote:
> _signingIn seems to be needed because you are using setInterval.
> 
> If you switch to setTimeout and recall setTimeout within then you won't have
to worry about calling _onSignin() more than once, and can drop _signingIn.

Excellent suggestion.  Done.

https://codereview.chromium.org/2344883002/diff/60001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/common/auth-signin.html:134: 
On 2016/09/20 at 12:58:18, jcgregorio wrote:
> No blank line here.

Done.

https://codereview.chromium.org/2344883002/diff/60001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/common/auth-signin.html:151:
console.log("reloading credentials");
On 2016/09/20 at 12:58:18, jcgregorio wrote:
> Is the console.log needed?

I would like to keep it in, so if it doesn't work as well in prod, or there is
some corner case, I might have an inkling as to what is going on.  I can remove
it later, once things have stabilized.

[jcgregorio, 2016-09-20 13:31:00]

lgtm

[kjlubick, 2016-09-20 13:36:05]

The CQ bit was checked by kjlubick@google.com

[commit-bot: I haz the power, 2016-09-20 13:36:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 13:36:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 13:36:17]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-infra-committers".
Note that this has nothing to do with OWNERS files.

[KevinL, 2016-09-20 13:36:19]

kjlubick@chromium.org changed reviewers:
+ kjlubick@chromium.org

[KevinL, 2016-09-20 13:36:20]

lgtm

[KevinL, 2016-09-20 13:36:24]

The CQ bit was checked by kjlubick@chromium.org

[commit-bot: I haz the power, 2016-09-20 13:36:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 13:39:53]

Description was changed from

==========
Let auth credentials autorefresh and fix new tab

The auth signin doesn't happen if the page
is opened in a new tab.  This is likely because the user 
is already logged in, so we just reuse the credentials.

Additionally, this prevents the credentials from expiring.

BUG=631047
==========

to

==========
Let auth credentials autorefresh and fix new tab

The auth signin doesn't happen if the page
is opened in a new tab.  This is likely because the user 
is already logged in, so we just reuse the credentials.

Additionally, this prevents the credentials from expiring.

BUG=631047

Committed:
https://github.com/luci/luci-py/commit/cd808e1138f16101899a9f6409eda3a647a41381
==========

[commit-bot: I haz the power, 2016-09-20 13:39:54]

Committed patchset #5 (id:80001) as
https://github.com/luci/luci-py/commit/cd808e1138f16101899a9f6409eda3a647a41381