Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Unified Diff: appengine/swarming/elements/res/imp/tasklist/task-filters.html

Issue 2338383002: Refactor prior to adding task-page (Closed) Base URL: git@github.com:luci/luci-py@master
Patch Set: Address nits Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/swarming/elements/res/imp/tasklist/task-filters.html
diff --git a/appengine/swarming/elements/res/imp/tasklist/task-filters.html b/appengine/swarming/elements/res/imp/tasklist/task-filters.html
index 8f2400f6470ed71c2fef0a55e36adf21b1a1598c..846db0d136949872583dad7c774c2583201e7905 100644
--- a/appengine/swarming/elements/res/imp/tasklist/task-filters.html
+++ b/appengine/swarming/elements/res/imp/tasklist/task-filters.html
@@ -59,9 +59,9 @@
value="{{_query}}"
default_value="">
</url-param>
- <url-param name="limit"
+ <url-param name="_limit"
default_value="200"
- value="{{limit}}">
+ value="{{_limit}}">
</url-param>
<div class="container horizontal layout">
@@ -136,13 +136,13 @@
</div>
<div class="side-by-side">
- <paper-input id="limit"
+ <paper-input id="_limit"
label="Limit Results"
auto-validate
min="0"
max="1000"
pattern="[0-9]+"
- value="{{limit}}">
+ value="{{_limit}}">
</paper-input>
</div>
</div>
@@ -188,7 +188,7 @@
},
query_params: {
type: Object,
- computed: "_extractQueryParams(_filters.*, limit)",
+ computed: "_extractQueryParams(_filters.*, _limit)",
notify: true,
},
@@ -225,15 +225,15 @@
}
}.bind(this));
params["tags"] = tags;
- var lim = Math.floor(this.limit)
+ var lim = parseInt(this._limit);
if (Number.isInteger(lim)) {
// Clamp the limit
lim = Math.max(lim, 1);
lim = Math.min(1000, lim);
- params["limit"] = [lim];
+ params["_limit"] = [lim];
// not !== because limit could be the string "900"
- if (this.limit != lim) {
- this.set("limit", lim);
+ if (this._limit != lim) {
+ this.set("_limit", lim);
}
}
return params;

Powered by Google App Engine
This is Rietveld 408576698