chromeos: Refactor D-Bus client type enum and stub vs. fake naming

chromeos: Refactor D-Bus client type enum and stub vs. fake naming

This is needed for other //chromeos/dbus refactoring for mus+ash.

* Rename stub to fake in DBusThreadManager and DBusClientBundle for consistency
with the Fake*Client implementations
* Extract DBusClientType into its own file
* Move --dbus-unstub-clients parsing into the same file so that the client name
strings are near the enum
* Add some simple unit tests for DBusThreadManager initialization

No functional changes.

BUG=644414
TEST=chromeos_unittests
TBR=peter@chromium.org

Committed: https://crrev.com/2b590999a25934d555ca191a2ad2f3e802a86203
Cr-Commit-Position: refs/heads/master@{#418569}

[James Cook, 2016-09-13 20:53:22]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 20:53:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-09-13 20:54:35]

jamescook@chromium.org changed reviewers:
+ stevenjb@chromium.org

[James Cook, 2016-09-13 20:54:36]

stevenjb, please take a look.

hashimoto, FYI.

I left things related to the --dbus-unstub-clients switch named "unstub" since I
didn't want to change the switch name, and I thought it would be good if code to
process the switch matched the switch name.

[commit-bot: I haz the power, 2016-09-13 20:57:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 20:57:52]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[stevenjb, 2016-09-13 21:31:49]

Thanks for doing the cleanup and adding tests!

LGTM with two minor changes:
* Rename ustub where mentioned
* For bonus points: Also add a properly named flag and log a deprecation warning
for the existing --unstub flag

https://codereview.chromium.org/2338063002/diff/20001/chromeos/dbus/dbus_clie...
File chromeos/dbus/dbus_client_types.h (right):

https://codereview.chromium.org/2338063002/diff/20001/chromeos/dbus/dbus_clie...
chromeos/dbus/dbus_client_types.h:50: ParseDBusUnstubClientsList(const
std::string& unstub_list);
Unstub ->
Unfake?
ForceReal?

(also ustub_list)

[James Cook, 2016-09-13 21:32:53]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 21:33:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-09-13 22:04:18]

I also:

* added --dbus-real-clients
* added an error if you use --dbus-unstub-clients
* left comments in the code about when it's OK to remove --dbus-unstub-clients
* emailed chromium-os-dev and the guy who said he uses the flag

https://codereview.chromium.org/2338063002/diff/20001/chromeos/dbus/dbus_clie...
File chromeos/dbus/dbus_client_types.h (right):

https://codereview.chromium.org/2338063002/diff/20001/chromeos/dbus/dbus_clie...
chromeos/dbus/dbus_client_types.h:50: ParseDBusUnstubClientsList(const
std::string& unstub_list);
On 2016/09/13 21:31:49, stevenjb wrote:
> Unstub ->
> Unfake?
> ForceReal?
> 
> (also ustub_list)

Done.

[James Cook, 2016-09-13 22:08:50]

jamescook@chromium.org changed reviewers:
+ sky@chromium.org

[James Cook, 2016-09-13 22:08:51]

sky, can I get a rubber-stamp for a rename touching //chrome/test and a couple
places in //chrome/browser ?

[James Cook, 2016-09-13 22:08:58]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 22:09:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stevenjb, 2016-09-13 22:34:43]

Changes lgtm, thanks!

[commit-bot: I haz the power, 2016-09-13 23:08:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 23:08:57]

Dry run: This issue passed the CQ dry run.

[sky, 2016-09-14 02:58:10]

LGTM

[James Cook, 2016-09-14 15:21:36]

Description was changed from

==========
chromeos: Refactor D-Bus client type enum and stub vs. fake naming

This is needed for other //chromeos/dbus refactoring for mus+ash.

* Rename stub to fake in DBusThreadManager and DBusClientBundle for consistency
with the Fake*Client implementations
* Extract DBusClientType into its own file
* Move --dbus-unstub-clients parsing into the same file so that the client name
strings are near the enum
* Add some simple unit tests for DBusThreadManager initialization

No functional changes.

BUG=644414
TEST=chromeos_unittests
==========

to

==========
chromeos: Refactor D-Bus client type enum and stub vs. fake naming

This is needed for other //chromeos/dbus refactoring for mus+ash.

* Rename stub to fake in DBusThreadManager and DBusClientBundle for consistency
with the Fake*Client implementations
* Extract DBusClientType into its own file
* Move --dbus-unstub-clients parsing into the same file so that the client name
strings are near the enum
* Add some simple unit tests for DBusThreadManager initialization

No functional changes.

BUG=644414
TEST=chromeos_unittests
TBR=peter@chromium.org
==========

[James Cook, 2016-09-14 15:22:38]

TBR peter@chromium.org for a chromeos dbus function rename touching
content/shell/browser/shell_browser_main_parts.cc

[James Cook, 2016-09-14 15:23:24]

jamescook@chromium.org changed reviewers:
+ peter@chromium.org

[James Cook, 2016-09-14 15:23:25]

TBR peter@chromium.org for a chromeos dbus function rename touching
content/shell/browser/shell_browser_main_parts.cc

[James Cook, 2016-09-14 15:23:31]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2016-09-14 15:23:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 15:29:04]

Description was changed from

==========
chromeos: Refactor D-Bus client type enum and stub vs. fake naming

This is needed for other //chromeos/dbus refactoring for mus+ash.

* Rename stub to fake in DBusThreadManager and DBusClientBundle for consistency
with the Fake*Client implementations
* Extract DBusClientType into its own file
* Move --dbus-unstub-clients parsing into the same file so that the client name
strings are near the enum
* Add some simple unit tests for DBusThreadManager initialization

No functional changes.

BUG=644414
TEST=chromeos_unittests
TBR=peter@chromium.org
==========

to

==========
chromeos: Refactor D-Bus client type enum and stub vs. fake naming

This is needed for other //chromeos/dbus refactoring for mus+ash.

* Rename stub to fake in DBusThreadManager and DBusClientBundle for consistency
with the Fake*Client implementations
* Extract DBusClientType into its own file
* Move --dbus-unstub-clients parsing into the same file so that the client name
strings are near the enum
* Add some simple unit tests for DBusThreadManager initialization

No functional changes.

BUG=644414
TEST=chromeos_unittests
TBR=peter@chromium.org
==========

[commit-bot: I haz the power, 2016-09-14 15:29:05]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-14 15:30:51]

Description was changed from

==========
chromeos: Refactor D-Bus client type enum and stub vs. fake naming

This is needed for other //chromeos/dbus refactoring for mus+ash.

* Rename stub to fake in DBusThreadManager and DBusClientBundle for consistency
with the Fake*Client implementations
* Extract DBusClientType into its own file
* Move --dbus-unstub-clients parsing into the same file so that the client name
strings are near the enum
* Add some simple unit tests for DBusThreadManager initialization

No functional changes.

BUG=644414
TEST=chromeos_unittests
TBR=peter@chromium.org
==========

to

==========
chromeos: Refactor D-Bus client type enum and stub vs. fake naming

This is needed for other //chromeos/dbus refactoring for mus+ash.

* Rename stub to fake in DBusThreadManager and DBusClientBundle for consistency
with the Fake*Client implementations
* Extract DBusClientType into its own file
* Move --dbus-unstub-clients parsing into the same file so that the client name
strings are near the enum
* Add some simple unit tests for DBusThreadManager initialization

No functional changes.

BUG=644414
TEST=chromeos_unittests
TBR=peter@chromium.org

Committed: https://crrev.com/2b590999a25934d555ca191a2ad2f3e802a86203
Cr-Commit-Position: refs/heads/master@{#418569}
==========

[commit-bot: I haz the power, 2016-09-14 15:30:53]

Patchset 4 (id:??) landed as
https://crrev.com/2b590999a25934d555ca191a2ad2f3e802a86203
Cr-Commit-Position: refs/heads/master@{#418569}