chromeos/dbus/cros_disks_client.cc - Issue 2338063002: chromeos: Refactor D-Bus client type enum and stub vs. fake naming

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/dbus/cros_disks_client.cc

Issue 2338063002: chromeos: Refactor D-Bus client type enum and stub vs. fake naming (Closed)

Patch Set: review comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/dbus/cros_disks_client.cc

diff --git a/chromeos/dbus/cros_disks_client.cc b/chromeos/dbus/cros_disks_client.cc

index 1567b67dc81dfe37a78e1253bba88b17f3e305ba..298657f7658f8e9e07b1dc41b0a5a3710a7fe019 100644

--- a/chromeos/dbus/cros_disks_client.cc

+++ b/chromeos/dbus/cros_disks_client.cc

@@ -634,7 +634,7 @@ CrosDisksClient::~CrosDisksClient() {}

CrosDisksClient* CrosDisksClient::Create(DBusClientImplementationType type) {

if (type == REAL_DBUS_CLIENT_IMPLEMENTATION)

return new CrosDisksClientImpl();

- DCHECK_EQ(STUB_DBUS_CLIENT_IMPLEMENTATION, type);

+ DCHECK_EQ(FAKE_DBUS_CLIENT_IMPLEMENTATION, type);

return new FakeCrosDisksClient();

}

« no previous file with comments | « chromeos/dbus/cros_disks_client.h ('k') | chromeos/dbus/dbus_client.h » ('j') | no next file with comments »