Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Side by Side Diff: chromeos/dbus/dbus_client.h

Issue 2338063002: chromeos: Refactor D-Bus client type enum and stub vs. fake naming (Closed)
Patch Set: review comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chromeos/dbus/cros_disks_client.cc ('k') | chromeos/dbus/dbus_client_bundle.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROMEOS_DBUS_DBUS_CLIENT_H_ 5 #ifndef CHROMEOS_DBUS_DBUS_CLIENT_H_
6 #define CHROMEOS_DBUS_DBUS_CLIENT_H_ 6 #define CHROMEOS_DBUS_DBUS_CLIENT_H_
7 7
8 #include "base/macros.h"
8 9
9 namespace dbus { 10 namespace dbus {
10 class Bus; 11 class Bus;
11 } // namespace dbus 12 } // namespace dbus
12 13
13 namespace chromeos { 14 namespace chromeos {
14 15
15 // Interface for all DBus clients handled by DBusThreadManager. It restricts 16 // Interface for all DBus clients handled by DBusThreadManager. It restricts
16 // access to the Init function to DBusThreadManager only to prevent 17 // access to the Init function to DBusThreadManager only to prevent
17 // incorrect calls. Stub clients may lift that restriction however. 18 // incorrect calls. Stub clients may lift that restriction however.
18 class DBusClient { 19 class DBusClient {
19 protected: 20 protected:
20 virtual ~DBusClient() {} 21 virtual ~DBusClient() {}
21 22
22 // This function is called by DBusThreadManager. Only in unit tests, which 23 // This function is called by DBusThreadManager. Only in unit tests, which
23 // don't use DBusThreadManager, this function can be called through Stub 24 // don't use DBusThreadManager, this function can be called through Stub
24 // implementations (they change Init's member visibility to public). 25 // implementations (they change Init's member visibility to public).
25 virtual void Init(dbus::Bus* bus) = 0; 26 virtual void Init(dbus::Bus* bus) = 0;
26 27
27 private: 28 private:
28 friend class DBusThreadManager; 29 friend class DBusThreadManager;
29 30
30 DISALLOW_ASSIGN(DBusClient); 31 DISALLOW_ASSIGN(DBusClient);
31 }; 32 };
32 33
33 } // namespace chromeos 34 } // namespace chromeos
34 35
35 #endif // CHROMEOS_DBUS_DBUS_CLIENT_H_ 36 #endif // CHROMEOS_DBUS_DBUS_CLIENT_H_
OLDNEW
« no previous file with comments | « chromeos/dbus/cros_disks_client.cc ('k') | chromeos/dbus/dbus_client_bundle.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698