chromeos/dbus/update_engine_client.cc - Issue 2338063002: chromeos: Refactor D-Bus client type enum and stub vs. fake naming

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/dbus/update_engine_client.cc

Issue 2338063002: chromeos: Refactor D-Bus client type enum and stub vs. fake naming (Closed)

Patch Set: review comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/dbus/update_engine_client.cc

diff --git a/chromeos/dbus/update_engine_client.cc b/chromeos/dbus/update_engine_client.cc

index b2ae229eab9d02b940990aa22b1c3567415965d8..0bd247ae1682faf23f45ff472695359fc6499275 100644

--- a/chromeos/dbus/update_engine_client.cc

+++ b/chromeos/dbus/update_engine_client.cc

@@ -600,7 +600,7 @@ UpdateEngineClient* UpdateEngineClient::Create(

DBusClientImplementationType type) {

if (type == REAL_DBUS_CLIENT_IMPLEMENTATION)

return new UpdateEngineClientImpl();

- DCHECK_EQ(STUB_DBUS_CLIENT_IMPLEMENTATION, type);

+ DCHECK_EQ(FAKE_DBUS_CLIENT_IMPLEMENTATION, type);

if (base::CommandLine::ForCurrentProcess()->HasSwitch(

switches::kTestAutoUpdateUI))

return new UpdateEngineClientFakeImpl();